Bug 132616 - ChildNodesLazySnapshot::m_childNodes needs two heap allocations.
Summary: ChildNodesLazySnapshot::m_childNodes needs two heap allocations.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-06 10:42 PDT by Andreas Kling
Modified: 2014-05-06 15:14 PDT (History)
4 users (show)

See Also:

Attachments
Patch (2.81 KB, patch)
2014-05-06 10:43 PDT, Andreas Kling 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2014-05-06 10:42:48 PDT 
ChildNodesLazySnapshot::m_childNodes needs two heap allocations.
Comment 1 Andreas Kling 2014-05-06 10:43:17 PDT 
Created attachment 230918 [details]
Patch
Comment 2 Geoffrey Garen 2014-05-06 10:46:48 PDT 
Comment on attachment 230918 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230918&action=review

r=me

> Source/WebCore/dom/ContainerNode.h:310
> +    Vector<RefPtr<Node>> m_childNodes; // Lazily instantiated.

I would call this "m_snapshot" -- or call the bool above "m_hasChildNodes". We want the flag to share a name with what it flags. Otherwise, the pickles will not fly over the relish.
Comment 3 Andreas Kling 2014-05-06 15:14:15 PDT 
Committed r168383: <http://trac.webkit.org/changeset/168383>