WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
132613
URI doesn't get updated for cached 301 redirects
https://bugs.webkit.org/show_bug.cgi?id=132613
Summary
URI doesn't get updated for cached 301 redirects
mschiffer
Reported
2014-05-06 10:07:55 PDT
Version: webkit2-gtk3.0 2.4.1 In webkit2, the "uri" property/the URI returned by webkit_web_view_get_uri() doesn't get updated after following a cached 301 redirect. When the request is made for the first time and is thus not cached, it gets updated correctly. I can reproduce this with both Epiphany and my own code. Webkit1 doesn't exhibit this behaviour.
Attachments
Bugfix
(3.20 KB, patch)
2014-05-09 09:07 PDT
,
mschiffer
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
mschiffer
Comment 1
2014-05-08 05:37:10 PDT
I've now further debugged this. The WebKitWebView never gets a load-changed signal with WEBKIT_LOAD_REDIRECTED for cached redirects, as it would normally be triggered by WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad(), which is called by ResourceLoader::willSendRequest(), but the ResourceLoader is not active for cached requests. I think to fix this, it'd be necessary to move the WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad() call to CachedRawResource or DocumentLoader. Does this make sense? I don't know the code very well, but if you agree with my analysis, I can try cooking up a patch.
mschiffer
Comment 2
2014-05-09 09:07:26 PDT
Created
attachment 231159
[details]
Bugfix This patch fixes the problem for me, both in Epiphany and my own application.
mschiffer
Comment 3
2014-05-17 03:03:51 PDT
Hi, it's been more that a week since I reported this bug *and* provided a patch. Anyone looked at it yet?
mschiffer
Comment 4
2014-06-14 07:31:52 PDT
It'd be really nice if I could a least get a reaction on my bug report, which is now over a month old.
mschiffer
Comment 5
2014-07-11 05:53:18 PDT
Pinging again. Anyone willing to look at this bug report? It's been two months since I provided a patch...
mschiffer
Comment 6
2014-08-17 02:05:21 PDT
I can't reproduce this bug with the current version (webkit2-gtk3 2.4.4) anymore, so I guess it's been fixed.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug