[GStreamer] Corrected typo
Created attachment 230909 [details] Patch
Comment on attachment 230909 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230909&action=review Please fix ChangeLog before landing. > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:208 > , m_timeOfOverlappingSeek(-1) > + , m_canFallBackToLastFinishedSeekPosition(false) > , m_buffering(false) This is a goo thing to add, I'd say, but you fail to mention it in the ChangeLog.
(In reply to comment #2) > > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:208 > > , m_timeOfOverlappingSeek(-1) > > + , m_canFallBackToLastFinishedSeekPosition(false) > > , m_buffering(false) > > This is a good thing to add, I'd say, but you fail to mention it in the ChangeLog. It is in the changelog. Should I add anything else?
Created attachment 230910 [details] Patch
Comment on attachment 230910 [details] Patch Rejecting attachment 230910 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'validate-changelog', '--check-oops', '--non-interactive', 230910, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/5328062841356288
Created attachment 230983 [details] Patch for landing
Comment on attachment 230983 [details] Patch for landing Clearing flags on attachment: 230983 Committed r168420: <http://trac.webkit.org/changeset/168420>
All reviewed patches have been landed. Closing bug.