Bug 132608 - REGRESSION: Animated GIF inside compositing layer never resumes animation when scrolled back into view
Summary: REGRESSION: Animated GIF inside compositing layer never resumes animation whe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-06 07:01 PDT by Antti Koivisto
Modified: 2014-05-07 06:12 PDT (History)
6 users (show)

See Also:


Attachments
patch (11.70 KB, patch)
2014-05-06 07:08 PDT, Antti Koivisto
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2014-05-06 07:01:18 PDT
yep
Comment 1 Antti Koivisto 2014-05-06 07:08:26 PDT
Created attachment 230905 [details]
patch
Comment 2 Antti Koivisto 2014-05-06 07:11:30 PDT
<rdar://problem/16462414>
Comment 3 Simon Fraser (smfr) 2014-05-06 08:29:03 PDT
Comment on attachment 230905 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230905&action=review

> LayoutTests/fast/repaint/animation-after-layer-scroll.html:18
> +        hasRepaintRects = window.internals.hasRepaintRectsIncludingSublayers();

Couldn't you have just got the repaint rects in JS and checked their emptiness?
Comment 4 Antti Koivisto 2014-05-06 13:41:42 PDT
(In reply to comment #3)
> Couldn't you have just got the repaint rects in JS and checked their emptiness?

That's what I tried first. There is currently no API for getting repaint rects except for sublayers and implementing one sensibly would have been more complicated than this.
Comment 5 Antti Koivisto 2014-05-06 13:42:17 PDT
I mean "no API for getting repaint rects for sublayers"
Comment 6 Simon Fraser (smfr) 2014-05-06 14:13:37 PDT
layerTreeAsText(LAYER_TREE_INCLUDES_REPAINT_RECTS)
Comment 7 Antti Koivisto 2014-05-07 06:12:58 PDT
http://trac.webkit.org/changeset/168424

> layerTreeAsText(LAYER_TREE_INCLUDES_REPAINT_RECTS)

Ah right. Switched the test case to use that.