Bug 132603 – [iOS] Animate AVPlayerLayer into and out of full screen

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Jer Noble]

[iOS] Animate AVPlayerLayer into and out of full screen

[Jer Noble]

Created attachment 230893 [details]
Patch

[Jer Noble]

<rdar://problem/16778157>

[Simon Fraser (smfr)]

Comment on attachment 230893 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230893&action=review

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:354
> +- (id)init

instancetype?

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:359
> +        self.masksToBounds = YES;
> +        self.videoLayerGravity = AVVideoLayerGravityResizeAspect;

Shouldn't use property syntax in the init method.

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:380
> +static FloatRect largestRectWithAspectRatioInsideRect(float aspectRatio, FloatRect rect)
> +{
> +    if (aspectRatio > rect.size().aspectRatio()) {
> +        float dy = rect.width() / aspectRatio - rect.height();
> +        rect.inflateY(dy / 2);
> +    } else {
> +        float dx = rect.height() * aspectRatio - rect.width();
> +        rect.inflateX(dx / 2);
> +    }
> +    return rect;
> +}

Pretty sure we have code elsewhere that does aspect-ratio sizing.

> Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:392
> +    FloatRect rootBounds;
> +    CALayer *parent = self;
> +    while ((parent = [parent superlayer]))
> +        rootBounds = [parent bounds];

This is weird. How do you know how far up you're walking? Which rect do you actually want?

[Jer Noble]

(In reply to comment #3)
> (From update of attachment 230893 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=230893&action=review
> 
> > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:354
> > +- (id)init
> 
> instancetype?

Changed.

> > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:359
> > +        self.masksToBounds = YES;
> > +        self.videoLayerGravity = AVVideoLayerGravityResizeAspect;
> 
> Shouldn't use property syntax in the init method.

Changed.

> > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:380
> > +static FloatRect largestRectWithAspectRatioInsideRect(float aspectRatio, FloatRect rect)
> > +{
> > +    if (aspectRatio > rect.size().aspectRatio()) {
> > +        float dy = rect.width() / aspectRatio - rect.height();
> > +        rect.inflateY(dy / 2);
> > +    } else {
> > +        float dx = rect.height() * aspectRatio - rect.width();
> > +        rect.inflateX(dx / 2);
> > +    }
> > +    return rect;
> > +}
> 
> Pretty sure we have code elsewhere that does aspect-ratio sizing.

We do (in RenderReplaced), but it's not generic.  I'll add this to GeometryUtils.h.

> > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:392
> > +    FloatRect rootBounds;
> > +    CALayer *parent = self;
> > +    while ((parent = [parent superlayer]))
> > +        rootBounds = [parent bounds];
> 
> This is weird. How do you know how far up you're walking? Which rect do you actually want?

We're looking for our window's root UIViewController's view's bounds.  I'll change this to pass in the view controller, and query it directly.

[Jer Noble]

Created attachment 230931 [details]
Patch for landing.

[Jer Noble]

Committed r168392: <http://trac.webkit.org/changeset/168392>