Bug 132594 - [iOS][WK2] WebKit2 does not set CanPreventNativeGestures on the platform events
Summary: [iOS][WK2] WebKit2 does not set CanPreventNativeGestures on the platform events
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Benjamin Poulain
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-05 18:08 PDT by Benjamin Poulain
Modified: 2014-05-07 01:30 PDT (History)
1 user (show)

See Also:

Attachments
Patch (5.00 KB, patch)
2014-05-05 18:08 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Patch (8.51 KB, patch)
2014-05-06 16:54 PDT, Benjamin Poulain 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Benjamin Poulain 2014-05-05 18:08:17 PDT 
[iOS][WK2] WebKit2 does not set CanPreventNativeGestures on the platform events
Comment 1 Benjamin Poulain 2014-05-05 18:08:39 PDT 
Created attachment 230875 [details]
Patch
Comment 2 Benjamin Poulain 2014-05-06 16:54:53 PDT 
Created attachment 230952 [details]
Patch
Comment 3 Benjamin Poulain 2014-05-06 17:02:18 PDT 
Comment on attachment 230952 [details]
Patch

Clearing flags on attachment: 230952

Committed r168393: <http://trac.webkit.org/changeset/168393>
Comment 4 Benjamin Poulain 2014-05-06 17:02:20 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 Csaba Osztrogonác 2014-05-07 01:22:38 PDT 
(In reply to comment #3)
> (From update of attachment 230952 [details])
> Clearing flags on attachment: 230952
> 
> Committed r168393: <http://trac.webkit.org/changeset/168393>

and the !IOS buildfix landed in https://trac.webkit.org/changeset/168414

bool allTouchPointsAreReleased() const is a member 
of WebTouchEvent, not WebPlatformTouchEvent.
Comment 6 Benjamin Poulain 2014-05-07 01:30:04 PDT 
(In reply to comment #5)
> (In reply to comment #3)
> > (From update of attachment 230952 [details] [details])
> > Clearing flags on attachment: 230952
> > 
> > Committed r168393: <http://trac.webkit.org/changeset/168393>
> 
> and the !IOS buildfix landed in https://trac.webkit.org/changeset/168414
> 
> bool allTouchPointsAreReleased() const is a member 
> of WebTouchEvent, not WebPlatformTouchEvent.

Sorry about that. Thanks for fixing.