Bug 132587 - remove unnecessary notImplemented.h inclusions
Summary: remove unnecessary notImplemented.h inclusions
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-05 16:50 PDT by Alex Christensen
Modified: 2014-05-06 11:33 PDT (History)
30 users (show)

See Also:

Attachments
Patch (15.95 KB, patch)
2014-05-05 16:55 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2014-05-05 16:50:30 PDT 
Things have been implemented.  If there's no notImplemented() in a file, then we shouldn't include notImplemented.h.
Comment 1 Alex Christensen 2014-05-05 16:55:58 PDT 
Created attachment 230868 [details]
Patch
Comment 2 WebKit Commit Bot 2014-05-06 11:05:23 PDT 
Comment on attachment 230868 [details]
Patch

Clearing flags on attachment: 230868

Committed r168367: <http://trac.webkit.org/changeset/168367>
Comment 3 WebKit Commit Bot 2014-05-06 11:05:37 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 4 Csaba Osztrogonác 2014-05-06 11:33:01 PDT 
(In reply to comment #2)
> (From update of attachment 230868 [details])
> Clearing flags on attachment: 230868
> 
> Committed r168367: <http://trac.webkit.org/changeset/168367>

It broke the debug build:

/Volumes/Data/slave/mountainlion-debug/build/Source/WebCore/platform/NotImplemented.cpp:34:16: error: no previous prototype for function 'notImplementedLoggingChannel' [-Werror,-Wmissing-prototypes]
WTFLogChannel* notImplementedLoggingChannel()