Bug 132582 - Stop using BlobData on client side
Summary: Stop using BlobData on client side
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-05 14:50 PDT by Alexey Proskuryakov
Modified: 2014-05-05 17:43 PDT (History)
1 user (show)

See Also:

Attachments
proposed patch (72.12 KB, patch)
2014-05-05 15:07 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
with a debug assertion fix (72.15 KB, patch)
2014-05-05 15:30 PDT, Alexey Proskuryakov 		sam: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-05-05 14:50:03 PDT 
BlobData has many data members that only make sense in BlobRegistryImpl, yet it's also used for blob registration on WebProcess side. This made us have some pretty nonsensical code.
Comment 1 Alexey Proskuryakov 2014-05-05 15:07:43 PDT 
Created attachment 230857 [details]
proposed patch

Starting with EWS...
Comment 2 WebKit Commit Bot 2014-05-05 15:09:02 PDT 
Attachment 230857 [details] did not pass style-queue:


ERROR: Source/WebCore/fileapi/Blob.h:99:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/fileapi/Blob.h:102:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 2 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2014-05-05 15:30:50 PDT 
Created attachment 230860 [details]
with a debug assertion fix
Comment 4 WebKit Commit Bot 2014-05-05 15:32:26 PDT 
Attachment 230860 [details] did not pass style-queue:


ERROR: Source/WebCore/fileapi/Blob.h:99:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
ERROR: Source/WebCore/fileapi/Blob.h:102:  enum members should use InterCaps with an initial capital letter.  [readability/enum_casing] [4]
Total errors found: 2 in 31 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 5 Alexey Proskuryakov 2014-05-05 17:43:52 PDT 
Committed <http://trac.webkit.org/r168333> (with a Windows fix).