Bug 132579 - Don't select an image that is about to have its menu shown.
Summary: Don't select an image that is about to have its menu shown.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-05 13:27 PDT by Brady Eidson
Modified: 2014-05-06 14:09 PDT (History)
1 user (show)

See Also:


Attachments
Patch v1 (6.57 KB, patch)
2014-05-06 09:23 PDT, Brady Eidson
thorton: review+
beidson: commit-queue?
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-05-05 13:27:51 PDT
Don't select an image that is about to be serviced.

Instead select it afterwards and before pasting the result.

<rdar://problem/16807845>
Comment 1 Brady Eidson 2014-05-06 09:23:01 PDT
Created attachment 230911 [details]
Patch v1
Comment 2 Tim Horton 2014-05-06 12:07:42 PDT
Comment on attachment 230911 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=230911&action=review

> Source/WebCore/editing/mac/EditorMac.mm:272
> +    if (&(node->document()) != m_frame.document())

Don't think you need the parens.

> Source/WebKit/mac/ChangeLog:10
> +          Call the new replaceNodeFromPasteboard API instead of readSelectionFromPasteboard.

extra space at the beginning of the line

> Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:125
> +    Node* node = page->contextMenuController().context().hitTestResult().innerNode();
> +    if (node) {

if (Node* node = ...)
Comment 3 Brady Eidson 2014-05-06 14:09:03 PDT
https://trac.webkit.org/r168378