Bug 132560 - Use a layer delegate instead of web_disableAllActions wherever possible
Summary: Use a layer delegate instead of web_disableAllActions wherever possible
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-05 02:06 PDT by Tim Horton
Modified: 2014-05-05 11:30 PDT (History)
5 users (show)

See Also:

Attachments
patch (35.33 KB, patch)
2014-05-05 02:56 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2014-05-05 02:06:09 PDT 
It turns out web_disableAllActions is surprisingly expensive.

<rdar://problem/16459284>
Comment 1 Tim Horton 2014-05-05 02:56:50 PDT 
Created attachment 230815 [details]
patch
Comment 2 WebKit Commit Bot 2014-05-05 02:58:38 PDT 
Attachment 230815 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/graphics/cocoa/WebCoreCALayerExtras.mm:35:  Missing space before {  [whitespace/braces] [5]
ERROR: Source/WebCore/platform/graphics/cocoa/WebCoreCALayerExtras.mm:36:  Missing space before {  [whitespace/braces] [5]
Total errors found: 2 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Simon Fraser (smfr) 2014-05-05 08:05:56 PDT 
Comment on attachment 230815 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230815&action=review

> Source/WebCore/platform/graphics/cocoa/WebCALayerController.h:29
> +@interface WebCALayerController : NSObject

I don't like the name; this class isn't a controller for layers. Maybe WebDefaultCALayerDelegate or something?
Comment 4 Tim Horton 2014-05-05 11:30:50 PDT 
http://trac.webkit.org/changeset/168301