RESOLVED FIXED 132560
Use a layer delegate instead of web_disableAllActions wherever possible 
https://bugs.webkit.org/show_bug.cgi?id=132560
Summary Use a layer delegate instead of web_disableAllActions wherever possible
Tim Horton
Reported 2014-05-05 02:06:09 PDT
It turns out web_disableAllActions is surprisingly expensive. <rdar://problem/16459284>
Attachments
patch (35.33 KB, patch)
2014-05-05 02:56 PDT, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2014-05-05 02:56:50 PDT
Created attachment 230815 [details] patch
WebKit Commit Bot
Comment 2 2014-05-05 02:58:38 PDT
Attachment 230815 [details] did not pass style-queue: ERROR: Source/WebCore/platform/graphics/cocoa/WebCoreCALayerExtras.mm:35: Missing space before { [whitespace/braces] [5] ERROR: Source/WebCore/platform/graphics/cocoa/WebCoreCALayerExtras.mm:36: Missing space before { [whitespace/braces] [5] Total errors found: 2 in 14 files If any of these errors are false positives, please file a bug against check-webkit-style.
Simon Fraser (smfr)
Comment 3 2014-05-05 08:05:56 PDT
Comment on attachment 230815 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=230815&action=review > Source/WebCore/platform/graphics/cocoa/WebCALayerController.h:29 > +@interface WebCALayerController : NSObject I don't like the name; this class isn't a controller for layers. Maybe WebDefaultCALayerDelegate or something?
Tim Horton
Comment 4 2014-05-05 11:30:50 PDT
http://trac.webkit.org/changeset/168301
Note You need to log in before you can comment on or make changes to this bug.