RESOLVED FIXED132559
[Soup] Use std::unique_ptr<char[]> for the read buffer in SocketStreamHandle 
https://bugs.webkit.org/show_bug.cgi?id=132559
Summary [Soup] Use std::unique_ptr<char[]> for the read buffer in SocketStreamHandle
Zan Dobersek
Reported 2014-05-04 23:49:28 PDT
[Soup] Use std::unique_ptr<char[]> for the read buffer in SocketStreamHandle
Attachments
Patch (4.52 KB, patch)
2014-05-04 23:59 PDT, Zan Dobersek 		cgarcia: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zan Dobersek
Comment 1 2014-05-04 23:59:56 PDT
Created attachment 230809 [details] Patch
Carlos Garcia Campos
Comment 2 2014-05-05 01:11:30 PDT
Comment on attachment 230809 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230809&action=review > Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp:87 > - , m_readBuffer(0) > + , m_readBuffer(nullptr) Do we really need to initialize a std:unique_ptr? doesn't it set the internal pointer to 0 in its constructor? > Source/WebCore/platform/network/soup/SocketStreamHandleSoup.cpp:102 > - , m_readBuffer(0) > + , m_readBuffer(nullptr) Ditto.
Carlos Garcia Campos
Comment 3 2014-05-05 01:12:03 PDT
Comment on attachment 230809 [details] Patch Forgot to change the flag :-P
Zan Dobersek
Comment 4 2014-05-05 23:20:35 PDT
Committed r168351: <http://trac.webkit.org/changeset/168351>
Note You need to log in before you can comment on or make changes to this bug.