RESOLVED FIXED 132539
Clear the JSString cache when under memory pressure. 
https://bugs.webkit.org/show_bug.cgi?id=132539
Summary Clear the JSString cache when under memory pressure.
Andreas Kling
Reported 2014-05-03 19:09:06 PDT
The JSString cache is a luxury for fast mapping from StringImpl* to JSString*. We should drop it under memory pressure.
Attachments
Patch (1.54 KB, patch)
2014-05-03 19:09 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-05-03 19:09:38 PDT
Created attachment 230779 [details] Patch
Sam Weinig
Comment 2 2014-05-03 19:18:38 PDT
Comment on attachment 230779 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230779&action=review > Source/WebCore/platform/MemoryPressureHandler.cpp:112 > + { > + ReliefLogger log("Clearing JS string cache"); > + JSDOMWindow::commonVM().stringCache.clear(); > + } We really need to find a way for this to be less of a layering violation haven.
WebKit Commit Bot
Comment 3 2014-05-03 20:22:33 PDT
Comment on attachment 230779 [details] Patch Clearing flags on attachment: 230779 Committed r168235: <http://trac.webkit.org/changeset/168235>
WebKit Commit Bot
Comment 4 2014-05-03 20:22:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.