[iOS WK2] Turn off position:fixed behavior when the keyboard is up

[Simon Fraser (smfr)]

[iOS WK2] Turn off position:fixed behavior when the keyboard is up

[Simon Fraser (smfr)]

Created attachment 230773 [details]
Patch

[Simon Fraser (smfr)]

Created attachment 230774 [details]
Patch

[Benjamin Poulain]

Comment on attachment 230774 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230774&action=review

Cool!

If you have time, it would be really nice to not freeze the layout in some cases. If you can fix the caret issue, I would be happy to come with the heuristic and fix the animation.

> Source/WebKit2/UIProcess/ios/WKContentView.mm:316
> +        _lastFixedPositionRect = fixedPositionRectFromExposedRect(unobscuredRect, [self bounds].size, zoomScale);

We should rename fixedPositionRectFromExposedRect() to fixedPositionRectFromUnobscuredRect() at some point.

[self bounds].size -> self.bounds.size.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2105
> +- (BOOL)_hasAssistedNode
> +{
> +    return _assistedNodeInformation.elementType != WKTypeNone;
> +}

Shouldn't you use "isEditable" and/or "isAssistingNode" instead?

[Simon Fraser (smfr)]

There's a problem when moving from one form field in a postion:fixed to the next, so I'll refine this patch.

[Jon Lee]

<rdar://problem/16665614>

[Simon Fraser (smfr)]

Comment on attachment 230774 [details]
Patch

Need to do something better than this.

[Simon Fraser (smfr)]

Created attachment 235244 [details]
Patch

[Benjamin Poulain]

Comment on attachment 235244 [details]
Patch

Looks reasonable.

Can you please force an updateVisibleContentRect from [WKContentView _startAssistingNode:] in if the focus succeed and the AssistedNodeInformation has insideFixedPosition? (if not you could remove insideFixedPosition entirely).

[Simon Fraser (smfr)]

https://trac.webkit.org/r171320