RESOLVED FIXED 132530
Allow CMake to find GLib on FreeBSD 
https://bugs.webkit.org/show_bug.cgi?id=132530
Summary Allow CMake to find GLib on FreeBSD
Myles C. Maxfield
Reported 2014-05-03 14:11:30 PDT
Allow CMake to find GLib on FreeBSD
Attachments
Patch (1.22 KB, patch)
2014-05-03 14:15 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Patch (1.27 KB, patch)
2014-05-16 18:13 PDT, Myles C. Maxfield 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Myles C. Maxfield
Comment 1 2014-05-03 14:15:15 PDT
Created attachment 230764 [details] Patch
Raphael Kubo da Costa (:rakuco)
Comment 2 2014-05-03 15:10:08 PDT
My local version looks like this instead. It achieves the same thing while being a bit more generic. Index: Source/cmake/FindGLIB.cmake =================================================================== --- Source/cmake/FindGLIB.cmake (revision 166850) +++ Source/cmake/FindGLIB.cmake (working copy) @@ -56,6 +56,7 @@ find_path(GLIBCONFIG_INCLUDE_DIR NAMES glibconfig.h HINTS ${PC_LIBDIR} ${PC_LIBRARY_DIRS} ${_GLIB_LIBRARY_DIR} + ${PC_GLIB_INCLUDEDIR} ${PC_GLIB_INCLUDE_DIRS} PATH_SUFFIXES glib-2.0/include ) I have mixed feelings about this since it's FreeBSD that shouldn't be patching glib to install glibconfig.h into a different location, but I guess the cat is already out of the bag at this point.
Myles C. Maxfield
Comment 3 2014-05-16 18:13:06 PDT
Created attachment 231608 [details] Patch
Gustavo Noronha (kov)
Comment 4 2014-08-01 06:29:16 PDT
Comment on attachment 231608 [details] Patch … yeah, but that should not cause any issues
WebKit Commit Bot
Comment 5 2014-08-01 17:46:41 PDT
Comment on attachment 231608 [details] Patch Clearing flags on attachment: 231608 Committed r171962: <http://trac.webkit.org/changeset/171962>
WebKit Commit Bot
Comment 6 2014-08-01 17:46:46 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.