Bug 132528 - [UI-side compositing] Assertion in PlatformCAFilters::setFiltersOnLayer with animated reference filter
Summary: [UI-side compositing] Assertion in PlatformCAFilters::setFiltersOnLayer with ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-03 12:59 PDT by Simon Fraser (smfr)
Modified: 2014-05-03 13:34 PDT (History)
2 users (show)

See Also:


Attachments
Patch (5.98 KB, patch)
2014-05-03 13:04 PDT, Simon Fraser (smfr)
no flags Details | Formatted Diff | Diff
Patch (6.05 KB, patch)
2014-05-03 13:06 PDT, Simon Fraser (smfr)
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2014-05-03 12:59:31 PDT
[UI-side compositing] Assertion in PlatformCAFilters::setFiltersOnLayer with animated reference filter
Comment 1 Simon Fraser (smfr) 2014-05-03 13:04:05 PDT
Created attachment 230761 [details]
Patch
Comment 2 Simon Fraser (smfr) 2014-05-03 13:04:49 PDT
<rdar://problem/16671660>
Comment 3 Simon Fraser (smfr) 2014-05-03 13:06:05 PDT
Reopening to attach new patch.
Comment 4 Simon Fraser (smfr) 2014-05-03 13:06:08 PDT
Created attachment 230762 [details]
Patch
Comment 5 Tim Horton 2014-05-03 13:08:49 PDT
Comment on attachment 230762 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230762&action=review

> Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1608
> +        decoder.markInvalid();

Does 'return false' not already indicate an invalid message?
Comment 6 Simon Fraser (smfr) 2014-05-03 13:33:42 PDT
https://trac.webkit.org/r168228
Comment 7 Simon Fraser (smfr) 2014-05-03 13:34:47 PDT
(In reply to comment #5)
> (From update of attachment 230762 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=230762&action=review
> 
> > Source/WebKit2/Shared/WebCoreArgumentCoders.cpp:1608
> > +        decoder.markInvalid();
> 
> Does 'return false' not already indicate an invalid message?

No, the lowest-level decoding is the one responsible for markInvalid().