There are two ways to get favicon database.
The first option is ewk_view_favicon_get with favicon,changed signal.
It always register the callback internally although applications does not want to use it.
The other option is ewk_favicon_database_icon_get with ewk_favicon_database_icon_change_callback_add API.
But callback don't know which icondatabase calls icon chages.
I will remove first option and improve ewk_favicon_database_icon_change_callback.
Created attachment 230746 [details]
Comment on attachment 230746 [details]
View in context: https://bugs.webkit.org/attachment.cgi?id=230746&action=review
> + It's simple to use but it always adds the callback to EwkView although applications does not use favicon.
I agree that we don't need to support two options to get favicon data. However, I don't think first option has big overhead to add favicon callback in application side. Anyway, I don't have pros to keep first way. So, r+ed.
> + * MiniBrowser/efl/main.c: Use ewk_view_favicon_get instead of ewk_view_favicon_get.
Use ewk_view_favicon_get instead of ewk_view_favicon_get. => Use ewk_favicon_database_icon_get instead of ewk_view_favicon_get. ?
> + Evas_Object* favicon = ewk_favicon_database_icon_get(database, url, evas_object_evas_get(ewk_view));
Looks wrong * place in Evas_Object* favicon
Committed r168265: <http://trac.webkit.org/changeset/168265>