Bug 132492 - Add Jeremy as a committer.
Summary: Add Jeremy as a committer.
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jeremy Jones
Depends on:
Reported: 2014-05-02 14:57 PDT by Jeremy Jones
Modified: 2014-05-03 09:48 PDT (History)
4 users (show)

See Also:

Patch (1.60 KB, patch)
2014-05-02 14:59 PDT, Jeremy Jones
jer.noble: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Jones 2014-05-02 14:57:22 PDT
Add Jeremy as a committer.
Comment 1 Jeremy Jones 2014-05-02 14:59:15 PDT
Created attachment 230703 [details]
Comment 2 WebKit Commit Bot 2014-05-02 15:01:45 PDT
Attachment 230703 [details] did not pass style-queue:

ERROR: Tools/Scripts/webkitpy/common/config/contributors.json:0:  contributors.json should not be modified through the commit queue  [json/syntax] [5]
Total errors found: 1 in 2 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2014-05-02 15:39:38 PDT
Comment on attachment 230703 [details]

Rejecting attachment 230703 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'apply-attachment', '--no-update', '--non-interactive', 230703, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
fs from patch file(s).
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/Scripts/webkitpy/common/config/contributors.json
Hunk #1 succeeded at 1237 with fuzz 1 (offset 8 lines).
Hunk #2 FAILED at 3041.
1 out of 2 hunks FAILED -- saving rejects to file Tools/Scripts/webkitpy/common/config/contributors.json.rej

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Jer Noble']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/5623722081779712
Comment 4 Csaba Osztrogonác 2014-05-03 09:47:42 PDT
You shouldn't have landed this patch with commit queue as the style 
queue noticed it. The committer should land this addition manually.