WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
132489
[Mac] -[_WKThumbnailView _requestSnapshotIfNeeded] assumes that taking a snapshot will always succeed
https://bugs.webkit.org/show_bug.cgi?id=132489
Summary
[Mac] -[_WKThumbnailView _requestSnapshotIfNeeded] assumes that taking a snap...
Mark Rowe (bdash)
Reported
2014-05-02 14:29:13 PDT
The takeSnapshot callback in -[_WKThumbnailView _requestSnapshotIfNeeded] assumes that taking the snapshot will always succeed. If it fails and the callback receives a null ShareableBitmap::Handle, as can happen if the WKView is closed while a snapshot request is pending, the callback will dereference null.
Attachments
Patch
(1.79 KB, patch)
2014-05-02 14:37 PDT
,
Mark Rowe (bdash)
thorton
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Mark Rowe (bdash)
Comment 1
2014-05-02 14:29:29 PDT
<
rdar://problem/16704660
>
Mark Rowe (bdash)
Comment 2
2014-05-02 14:37:04 PDT
Created
attachment 230702
[details]
Patch
Mark Rowe (bdash)
Comment 3
2014-05-02 15:04:32 PDT
Committed
r168195
: <
http://trac.webkit.org/changeset/168195
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug