Bug 132489 - [Mac] -[_WKThumbnailView _requestSnapshotIfNeeded] assumes that taking a snapshot will always succeed
Summary: [Mac] -[_WKThumbnailView _requestSnapshotIfNeeded] assumes that taking a snap...
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Rowe (bdash)
Keywords: InRadar
Depends on:
Reported: 2014-05-02 14:29 PDT by Mark Rowe (bdash)
Modified: 2014-05-02 15:04 PDT (History)
0 users

See Also:

Patch (1.79 KB, patch)
2014-05-02 14:37 PDT, Mark Rowe (bdash)
thorton: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Rowe (bdash) 2014-05-02 14:29:13 PDT
The takeSnapshot callback in -[_WKThumbnailView _requestSnapshotIfNeeded] assumes that taking the snapshot will always succeed. If it fails and the callback receives a null ShareableBitmap::Handle, as can happen if the WKView is closed while a snapshot request is pending, the callback will dereference null.
Comment 1 Mark Rowe (bdash) 2014-05-02 14:29:29 PDT
Comment 2 Mark Rowe (bdash) 2014-05-02 14:37:04 PDT
Created attachment 230702 [details]
Comment 3 Mark Rowe (bdash) 2014-05-02 15:04:32 PDT
Committed r168195: <http://trac.webkit.org/changeset/168195>