Bug 132484 - Implement new delegate method -sharingService:sourceFrameOnScreenForShareItem:
Summary: Implement new delegate method -sharingService:sourceFrameOnScreenForShareItem:
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-02 13:23 PDT by Brady Eidson
Modified: 2022-02-28 04:09 PST (History)
1 user (show)

See Also:

Attachments
Patch v1 (3.83 KB, patch)
2014-05-02 13:24 PDT, Brady Eidson 		thorton: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-05-02 13:23:29 PDT 
Implement new delegate method -sharingService:sourceFrameOnScreenForShareItem:

<rdar://problem/16797425>
Comment 1 Brady Eidson 2014-05-02 13:24:40 PDT 
Created attachment 230690 [details]
Patch v1
Comment 2 Tim Horton 2014-05-02 13:45:08 PDT 
Comment on attachment 230690 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=230690&action=review

> Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:373
> +    Node* node = page->contextMenuController().context().hitTestResult().innerNode();

any reason to null check node?

> Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:384
> +        ASSERT_NOT_REACHED();

why this assert, and then a happy handling of it on the next line?
Comment 3 Brady Eidson 2014-05-02 14:40:49 PDT 
(In reply to comment #2)
> (From update of attachment 230690 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=230690&action=review
> 
> > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:373
> > +    Node* node = page->contextMenuController().context().hitTestResult().innerNode();
> 
> any reason to null check node?

Good point.

> 
> > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:384
> > +        ASSERT_NOT_REACHED();
> 
> why this assert, and then a happy handling of it on the next line?

For the same reason we need to null check node - WebContextMenuClient handles all types of content menu invocations, including ones that are not about anything that deserves a rect or that have already rendered.
Comment 4 Brady Eidson 2014-05-02 14:44:15 PDT 
https://trac.webkit.org/changeset/168193