RESOLVED FIXED 132484
Implement new delegate method -sharingService:sourceFrameOnScreenForShareItem: 
https://bugs.webkit.org/show_bug.cgi?id=132484
Summary Implement new delegate method -sharingService:sourceFrameOnScreenForShareItem:
Brady Eidson
Reported 2014-05-02 13:23:29 PDT
Implement new delegate method -sharingService:sourceFrameOnScreenForShareItem: <rdar://problem/16797425>
Attachments
Patch v1 (3.83 KB, patch)
2014-05-02 13:24 PDT, Brady Eidson 		thorton: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brady Eidson
Comment 1 2014-05-02 13:24:40 PDT
Created attachment 230690 [details] Patch v1
Tim Horton
Comment 2 2014-05-02 13:45:08 PDT
Comment on attachment 230690 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=230690&action=review > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:373 > + Node* node = page->contextMenuController().context().hitTestResult().innerNode(); any reason to null check node? > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:384 > + ASSERT_NOT_REACHED(); why this assert, and then a happy handling of it on the next line?
Brady Eidson
Comment 3 2014-05-02 14:40:49 PDT
(In reply to comment #2) > (From update of attachment 230690 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=230690&action=review > > > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:373 > > + Node* node = page->contextMenuController().context().hitTestResult().innerNode(); > > any reason to null check node? Good point. > > > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:384 > > + ASSERT_NOT_REACHED(); > > why this assert, and then a happy handling of it on the next line? For the same reason we need to null check node - WebContextMenuClient handles all types of content menu invocations, including ones that are not about anything that deserves a rect or that have already rendered.
Brady Eidson
Comment 4 2014-05-02 14:44:15 PDT
https://trac.webkit.org/changeset/168193
Note You need to log in before you can comment on or make changes to this bug.