Bug 132474 - REGRESSION (r168095): 1-pixel gap between adjacent selection inlines
Summary: REGRESSION (r168095): 1-pixel gap between adjacent selection inlines
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P1 Normal
Assignee: zalan
URL: data:text/html,<div>You%20can%20<span...
Keywords: HasReduction, InRadar, Regression
Depends on:
Blocks:
 
Reported: 2014-05-02 11:32 PDT by mitz
Modified: 2014-05-13 07:43 PDT (History)
18 users (show)

See Also:


Attachments
Patch (32.12 KB, patch)
2014-05-05 21:10 PDT, zalan
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2 (472.59 KB, application/zip)
2014-05-05 22:17 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion (544.47 KB, application/zip)
2014-05-05 23:02 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (547.38 KB, application/zip)
2014-05-06 00:11 PDT, Build Bot
no flags Details
Patch (40.32 KB, patch)
2014-05-07 13:00 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (43.67 KB, patch)
2014-05-07 16:03 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (43.93 KB, patch)
2014-05-07 20:13 PDT, zalan
no flags Details | Formatted Diff | Diff
Patch (44.02 KB, patch)
2014-05-08 20:11 PDT, zalan
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-05-02 11:32:50 PDT
To reproduce the bug, navigate to the URL and Select All.
Comment 1 Radar WebKit Bug Importer 2014-05-02 11:33:40 PDT
<rdar://problem/16797394>
Comment 2 zalan 2014-05-02 11:38:33 PDT
This is caused by the integral inline text positioning.
Comment 3 zalan 2014-05-05 21:10:43 PDT
Created attachment 230884 [details]
Patch
Comment 4 zalan 2014-05-05 21:20:30 PDT
Now that directional snapping is removed from Font, adjustSelectionRectForText returns unsnapped coordinates, but they are either device pixel snapped (directional snapping) or enclosing integral snapped (no directional is needed there as rect is expanded in both directions.). -tracked here bug 132598
Comment 5 Build Bot 2014-05-05 22:17:37 PDT
Comment on attachment 230884 [details]
Patch

Attachment 230884 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6134904794382336

New failing tests:
fast/block/line-layout/selection-highlight-overlap.html
editing/selection/block-cursor-overtype-mode.html
Comment 6 Build Bot 2014-05-05 22:17:44 PDT
Created attachment 230887 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 7 Build Bot 2014-05-05 23:02:25 PDT
Comment on attachment 230884 [details]
Patch

Attachment 230884 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5333962381590528

New failing tests:
editing/selection/block-cursor-overtype-mode.html
svg/text/caret-in-svg-text.xhtml
fast/block/line-layout/selection-highlight-overlap.html
editing/selection/mixed-editability-10.html
fast/forms/cursor-at-editable-content-boundary.html
platform/mac/editing/input/caret-primary-bidi.html
Comment 8 Build Bot 2014-05-05 23:02:33 PDT
Created attachment 230890 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 9 Build Bot 2014-05-06 00:11:17 PDT
Comment on attachment 230884 [details]
Patch

Attachment 230884 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5873240354324480

New failing tests:
editing/selection/block-cursor-overtype-mode.html
svg/text/caret-in-svg-text.xhtml
fast/block/line-layout/selection-highlight-overlap.html
editing/selection/mixed-editability-10.html
fast/forms/cursor-at-editable-content-boundary.html
platform/mac/editing/input/caret-primary-bidi.html
Comment 10 Build Bot 2014-05-06 00:11:23 PDT
Created attachment 230891 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 11 zalan 2014-05-07 13:00:48 PDT
Created attachment 231011 [details]
Patch
Comment 12 zalan 2014-05-07 16:03:52 PDT
Created attachment 231027 [details]
Patch
Comment 13 zalan 2014-05-07 20:13:20 PDT
Created attachment 231038 [details]
Patch
Comment 14 Dave Hyatt 2014-05-08 13:31:56 PDT
Comment on attachment 231038 [details]
Patch

r=me
Comment 15 zalan 2014-05-08 20:11:32 PDT
Created attachment 231124 [details]
Patch
Comment 16 zalan 2014-05-08 20:11:55 PDT
Comment on attachment 231124 [details]
Patch

EWSing
Comment 17 WebKit Commit Bot 2014-05-09 07:21:18 PDT
Comment on attachment 231124 [details]
Patch

Clearing flags on attachment: 231124

Committed r168528: <http://trac.webkit.org/changeset/168528>
Comment 18 WebKit Commit Bot 2014-05-09 07:21:27 PDT
All reviewed patches have been landed.  Closing bug.
Comment 19 Dirk Schulze 2014-05-13 07:15:17 PDT
It is very likely that this completely broke text selection in SVG. It regressed between r168524 and r168595.

Here is a short example: http://jsfiddle.net/9kj2M/

Try to select the text.
Comment 20 zalan 2014-05-13 07:18:22 PDT
(In reply to comment #19)
> It is very likely that this completely broke text selection in SVG. It regressed between r168524 and r168595.
> 
> Here is a short example: http://jsfiddle.net/9kj2M/
> 
> Try to select the text.
Indeed. Looking into now.
Comment 21 zalan 2014-05-13 07:43:22 PDT
(In reply to comment #20)
> (In reply to comment #19)
> > It is very likely that this completely broke text selection in SVG. It regressed between r168524 and r168595.
> > 
> > Here is a short example: http://jsfiddle.net/9kj2M/
> > 
> > Try to select the text.
> Indeed. Looking into now.(In reply to comment #20)
> (In reply to comment #19)
> > It is very likely that this completely broke text selection in SVG. It regressed between r168524 and r168595.
> > 
> > Here is a short example: http://jsfiddle.net/9kj2M/
> > 
> > Try to select the text.
> Indeed. Looking into now.
Patch is coming up: bug 132868