Bug 132463 – [Mac] Allow MediaPlayerPrivate to control object-fit via videoGravity.

• Status: NEW
• Component: New Bugs

[Jer Noble]

[Mac] Allow MediaPlayerPrivate to control object-fit via videoGravity.

[Jer Noble]

Created attachment 230652 [details]
Patch

[Build Bot]

Comment on attachment 230652 [details]
Patch

Attachment 230652 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5727633446797312

New failing tests:
media/video-poster-background.html

[Build Bot]

Created attachment 230654 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 230652 [details]
Patch

Attachment 230652 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6486378074341376

New failing tests:
media/video-poster-background.html

[Build Bot]

Created attachment 230662 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Eric Carlson]

Comment on attachment 230652 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230652&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:437
> -    [m_synchronizer setRate:(m_playing ? m_rate : 0) time:toCMTime(seekTime)];
> +    [m_synchronizer setRate:0];
> +    [m_synchronizer setRate:0 time:toCMTime(seekTime)];

Is this supposed to be part of the same patch?

[Jer Noble]

(In reply to comment #6)
> (From update of attachment 230652 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=230652&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:437
> > -    [m_synchronizer setRate:(m_playing ? m_rate : 0) time:toCMTime(seekTime)];
> > +    [m_synchronizer setRate:0];
> > +    [m_synchronizer setRate:0 time:toCMTime(seekTime)];
> 
> Is this supposed to be part of the same patch?

Whoops, no. I'll post a new patch with a win port fix and without this diff.

[Brent Fulgham]

Comment on attachment 230652 [details]
Patch

Patch is too old to apply cleanly, and caused a number of tests to fail. Can you please update against current sources and fix the test failures?

[Radar WebKit Bug Importer]

<rdar://problem/25512976>