Bug 132463 - [Mac] Allow MediaPlayerPrivate to control object-fit via videoGravity.
Summary: [Mac] Allow MediaPlayerPrivate to control object-fit via videoGravity.
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jer Noble
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-01 22:05 PDT by Jer Noble
Modified: 2016-04-02 18:22 PDT (History)
11 users (show)

See Also:

Attachments
Patch (25.85 KB, patch)
2014-05-01 22:40 PDT, Jer Noble 		bfulgham: review-
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion (553.04 KB, application/zip)
2014-05-01 23:21 PDT, Build Bot 		no flags Details
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (535.31 KB, application/zip)
2014-05-02 03:13 PDT, Build Bot 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jer Noble 2014-05-01 22:05:54 PDT 
[Mac] Allow MediaPlayerPrivate to control object-fit via videoGravity.
Comment 1 Jer Noble 2014-05-01 22:40:26 PDT 
Created attachment 230652 [details]
Patch
Comment 2 Build Bot 2014-05-01 23:21:27 PDT 
Comment on attachment 230652 [details]
Patch

Attachment 230652 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5727633446797312

New failing tests:
media/video-poster-background.html
Comment 3 Build Bot 2014-05-01 23:21:30 PDT 
Created attachment 230654 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5
Comment 4 Build Bot 2014-05-02 03:13:53 PDT 
Comment on attachment 230652 [details]
Patch

Attachment 230652 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6486378074341376

New failing tests:
media/video-poster-background.html
Comment 5 Build Bot 2014-05-02 03:13:59 PDT 
Created attachment 230662 [details]
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-12  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5
Comment 6 Eric Carlson 2014-05-02 06:47:28 PDT 
Comment on attachment 230652 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230652&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:437
> -    [m_synchronizer setRate:(m_playing ? m_rate : 0) time:toCMTime(seekTime)];
> +    [m_synchronizer setRate:0];
> +    [m_synchronizer setRate:0 time:toCMTime(seekTime)];

Is this supposed to be part of the same patch?
Comment 7 Jer Noble 2014-05-02 08:30:01 PDT 
(In reply to comment #6)
> (From update of attachment 230652 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=230652&action=review
> 
> > Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:437
> > -    [m_synchronizer setRate:(m_playing ? m_rate : 0) time:toCMTime(seekTime)];
> > +    [m_synchronizer setRate:0];
> > +    [m_synchronizer setRate:0 time:toCMTime(seekTime)];
> 
> Is this supposed to be part of the same patch?

Whoops, no. I'll post a new patch with a win port fix and without this diff.
Comment 8 Brent Fulgham 2016-03-14 11:27:28 PDT 
Comment on attachment 230652 [details]
Patch

Patch is too old to apply cleanly, and caused a number of tests to fail. Can you please update against current sources and fix the test failures?
Comment 9 Radar WebKit Bug Importer 2016-04-02 18:22:43 PDT 
<rdar://problem/25512976>