Bug 132454 - REGRESSION (WebKit2) Need to support Learn button
Summary: REGRESSION (WebKit2) Need to support Learn button
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: iPhone / iPad Unspecified
: P2 Normal
Assignee: Enrica Casucci
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-01 18:07 PDT by Enrica Casucci
Modified: 2014-05-01 18:40 PDT (History)
0 users

See Also:

Attachments
Patch (4.08 KB, patch)
2014-05-01 18:11 PDT, Enrica Casucci 		benjamin: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Enrica Casucci 2014-05-01 18:07:01 PDT 
Need to add support for the Learn button in the menu for Traditional Chinese.

<rdar://problem/16778889>
Comment 1 Enrica Casucci 2014-05-01 18:11:40 PDT 
Created attachment 230638 [details]
Patch
Comment 2 Benjamin Poulain 2014-05-01 18:21:14 PDT 
Comment on attachment 230638 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230638&action=review

> Source/WebKit2/ChangeLog:12
> +        the button when appropriate as well as the implemetation of the action

typo: implemetation

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:838
> +    CGRect presentationRect = _page->editorState().selectionRects[0].rect();

You don't need to create this outside of the if() branch.

The compiler cannot optimize this out because of the objc-msgsend below.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:920
> +        if (!UIKeyboardEnabledInputModesAllowOneToManyShortcuts())

lol at the name :)
Comment 3 Enrica Casucci 2014-05-01 18:40:53 PDT 
Committed revision 168142.