Bug 132452 - Update service picker API usage
Summary: Update service picker API usage
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-05-01 17:43 PDT by Brady Eidson
Modified: 2014-05-01 20:32 PDT (History)
2 users (show)

See Also:

Attachments
Patch v1 (8.64 KB, patch)
2014-05-01 17:47 PDT, Brady Eidson 		thorton: review+
thorton: commit-queue-
Details | Formatted Diff | Diff
Patch for landing (8.63 KB, patch)
2014-05-01 19:55 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-05-01 17:43:12 PDT 
Update service picker API usage

<rdar://problem/16772674>
Comment 1 Brady Eidson 2014-05-01 17:47:54 PDT 
Created attachment 230635 [details]
Patch v1
Comment 2 WebKit Commit Bot 2014-05-01 17:49:08 PDT 
Attachment 230635 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:171:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Tim Horton 2014-05-01 18:08:17 PDT 
Comment on attachment 230635 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=230635&action=review

> Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:113
> +        data = [nsImage.get() TIFFRepresentation];

no .get()

> Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:166
> +        [self didShareImageData :[item TIFFRepresentation] confirmDataIsValidTIFFData:NO];

colon is in way the wrong place

> Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:169
> +        NSString *itemUTI = itemProvider.registeredTypeIdentifiers.firstObject;

firstObject is not available on ML IIRC

> Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:370
> +        RetainPtr<CFDataRef> cfdata = data->createCFData();

capital D
Comment 4 Tim Horton 2014-05-01 18:08:40 PDT 
(In reply to comment #3)
> (From update of attachment 230635 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=230635&action=review
> 
> > Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:113
> > +        data = [nsImage.get() TIFFRepresentation];
> 
> no .get()
> 
> > Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:166
> > +        [self didShareImageData :[item TIFFRepresentation] confirmDataIsValidTIFFData:NO];
> 
> colon is in way the wrong place
> 
> > Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:169
> > +        NSString *itemUTI = itemProvider.registeredTypeIdentifiers.firstObject;
> 
> firstObject is not available on ML IIRC

Neither is this code, never mind.

> > Source/WebKit/mac/WebCoreSupport/WebContextMenuClient.mm:370
> > +        RetainPtr<CFDataRef> cfdata = data->createCFData();
> 
> capital D
Comment 5 Brady Eidson 2014-05-01 19:55:34 PDT 
Created attachment 230646 [details]
Patch for landing
Comment 6 WebKit Commit Bot 2014-05-01 19:56:11 PDT 
Attachment 230646 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/Misc/WebSharingServicePickerController.mm:171:  Place brace on its own line for function definitions.  [whitespace/braces] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 7 WebKit Commit Bot 2014-05-01 20:32:11 PDT 
Comment on attachment 230646 [details]
Patch for landing

Clearing flags on attachment: 230646

Committed r168145: <http://trac.webkit.org/changeset/168145>
Comment 8 WebKit Commit Bot 2014-05-01 20:32:13 PDT 
All reviewed patches have been landed.  Closing bug.