Bug 132448 - Support OS-version-specific install paths for WebKit.framework
Summary: Support OS-version-specific install paths for WebKit.framework
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-01 16:09 PDT by Anders Carlsson
Modified: 2014-05-01 17:34 PDT (History)
1 user (show)

See Also:

Attachments
Patch (5.50 KB, patch)
2014-05-01 16:14 PDT, Anders Carlsson 		no flags Details | Formatted Diff | Diff
Patch (4.84 KB, patch)
2014-05-01 17:25 PDT, Anders Carlsson 		mitz: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2014-05-01 16:09:55 PDT 
Support OS-version-specific install paths for WebKit.framework
Comment 1 Anders Carlsson 2014-05-01 16:14:13 PDT 
Created attachment 230623 [details]
Patch
Comment 2 Anders Carlsson 2014-05-01 17:25:34 PDT 
Created attachment 230631 [details]
Patch
Comment 3 WebKit Commit Bot 2014-05-01 17:27:59 PDT 
Attachment 230631 [details] did not pass style-queue:


ERROR: Source/WebKit/mac/WebKitLegacy/WebKit.m:33:  Extra space before ( in function call  [whitespace/parens] [4]
Total errors found: 1 in 4 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 mitz 2014-05-01 17:29:33 PDT 
Comment on attachment 230631 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230631&action=review

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:2147
> +			runOnlyForDeploymentPostprocessing = 0;

This should be 1, and you can skip the SKIP_INSTALL test below.
Comment 5 Anders Carlsson 2014-05-01 17:34:34 PDT 
Committed r168138: <http://trac.webkit.org/changeset/168138>