Bug 132443 – CSS-based Media Controls Show Different times content longer than 1 hour.

• Status: RESOLVED
• Resolution: FIXED
• Component: Media

[Jeremy Jones]

CSS-based Media Controls Show Different times content longer than 1 hour.

[Jeremy Jones]

Created attachment 230619 [details]
Patch

[Jer Noble]

Comment on attachment 230619 [details]
Patch

Nice! r=me.

[Build Bot]

Comment on attachment 230619 [details]
Patch

Attachment 230619 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5643440008200192

New failing tests:
media/controls-without-preload.html
media/video-no-audio.html
media/controls-strict.html
media/audio-controls-rendering.html
media/controls-after-reload.html

[Build Bot]

Created attachment 230630 [details]
Archive of layout-test-results from webkit-ews-05 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-05  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 230619 [details]
Patch

Attachment 230619 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/6218291852869632

New failing tests:
media/controls-without-preload.html
media/video-no-audio.html
media/controls-strict.html
media/audio-controls-rendering.html

[Build Bot]

Created attachment 230636 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 230619 [details]
Patch

Attachment 230619 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6237186487746560

New failing tests:
media/controls-without-preload.html
media/video-no-audio.html
media/controls-strict.html
media/audio-controls-rendering.html
media/controls-after-reload.html

[Build Bot]

Created attachment 230639 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Jeremy Jones]

Created attachment 230667 [details]
Patch

[Jeremy Jones]

(In reply to comment #2)
> (From update of attachment 230619 [details])
> Nice! r=me.

One more small change to pass tests. Mac always wants two digit minutes.

[WebKit Commit Bot]

Comment on attachment 230667 [details]
Patch

Rejecting attachment 230667 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 230667 [details]
Patch

Rejecting attachment 230667 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 230667 [details]
Patch

Rejecting attachment 230667 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 230667 [details]
Patch

Rejecting attachment 230667 [details] from commit-queue.

[e-mail] does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.

[WebKit Commit Bot]

Comment on attachment 230667 [details]
Patch

Clearing flags on attachment: 230667

Committed r168215: <http://trac.webkit.org/changeset/168215>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Xabier Rodríguez Calvar]

Sorry for the late comment, but I think it would have been awesome to have a test about this.

[Jon Lee]

<rdar://problem/16173777>