RESOLVED FIXED 132439
Move size computation for Blob constructor into BlobRegistryImpl 
https://bugs.webkit.org/show_bug.cgi?id=132439
Summary Move size computation for Blob constructor into BlobRegistryImpl
Alexey Proskuryakov
Reported 2014-05-01 14:15:45 PDT
Blob constructor takes several blobs and combines them into one. We should do more of that in the registry, where the knowledge of the actual data is.
Attachments
proposed patch (29.14 KB, patch)
2014-05-01 14:31 PDT, Alexey Proskuryakov 		sam: review+
DetailsFormatted DiffDiff
patch for landing (29.82 KB, patch)
2014-05-01 15:30 PDT, Alexey Proskuryakov 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Alexey Proskuryakov
Comment 1 2014-05-01 14:31:44 PDT
Created attachment 230609 [details] proposed patch
WebKit Commit Bot
Comment 2 2014-05-01 14:33:40 PDT
Attachment 230609 [details] did not pass style-queue: ERROR: Source/WebCore/platform/network/BlobRegistryImpl.cpp:143: Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons. [readability/comparison_to_zero] [5] Total errors found: 1 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Alexey Proskuryakov
Comment 3 2014-05-01 15:30:41 PDT
Created attachment 230617 [details] patch for landing With build and threading fixes (forgot to add a semaphore).
WebKit Commit Bot
Comment 4 2014-05-01 16:09:58 PDT
Comment on attachment 230617 [details] patch for landing Clearing flags on attachment: 230617 Committed r168126: <http://trac.webkit.org/changeset/168126>
WebKit Commit Bot
Comment 5 2014-05-01 16:10:01 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.