Bug 132439 - Move size computation for Blob constructor into BlobRegistryImpl
Summary: Move size computation for Blob constructor into BlobRegistryImpl
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-05-01 14:15 PDT by Alexey Proskuryakov
Modified: 2014-05-01 16:10 PDT (History)
1 user (show)

See Also:

Attachments
proposed patch (29.14 KB, patch)
2014-05-01 14:31 PDT, Alexey Proskuryakov 		sam: review+
Details | Formatted Diff | Diff
patch for landing (29.82 KB, patch)
2014-05-01 15:30 PDT, Alexey Proskuryakov 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2014-05-01 14:15:45 PDT 
Blob constructor takes several blobs and combines them into one. We should do more of that in the registry, where the knowledge of the actual data is.
Comment 1 Alexey Proskuryakov 2014-05-01 14:31:44 PDT 
Created attachment 230609 [details]
proposed patch
Comment 2 WebKit Commit Bot 2014-05-01 14:33:40 PDT 
Attachment 230609 [details] did not pass style-queue:


ERROR: Source/WebCore/platform/network/BlobRegistryImpl.cpp:143:  Tests for true/false, null/non-null, and zero/non-zero should all be done without equality comparisons.  [readability/comparison_to_zero] [5]
Total errors found: 1 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Alexey Proskuryakov 2014-05-01 15:30:41 PDT 
Created attachment 230617 [details]
patch for landing

With build and threading fixes (forgot to add a semaphore).
Comment 4 WebKit Commit Bot 2014-05-01 16:09:58 PDT 
Comment on attachment 230617 [details]
patch for landing

Clearing flags on attachment: 230617

Committed r168126: <http://trac.webkit.org/changeset/168126>
Comment 5 WebKit Commit Bot 2014-05-01 16:10:01 PDT 
All reviewed patches have been landed.  Closing bug.