Often times when debugging using bytecode ranges isn't enough to narrow down to the particular DFG block that's causing issues. We should add the ability to whitelist specific functions specified in a file to enable further filtering without having to recompile.
Created attachment 230605 [details] Patch
Attachment 230605 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/Options.h:313: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 1 in 10 files If any of these errors are false positives, please file a bug against check-webkit-style.
Boo, apparently strnstr and fgetln are BSD-only. So lame.
Comment on attachment 230605 [details] Patch Plz fix.
Created attachment 230615 [details] Patch
Attachment 230615 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/Options.h:313: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 230615 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230615&action=review > Source/JavaScriptCore/bytecode/CodeBlock.cpp:3596 > + if (!profile) > + dataLog("Got null profile for bytecode ", bytecodeOffset, " in code block ", *this, "\n"); Remove.
Comment on attachment 230615 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230615&action=review > Source/JavaScriptCore/dfg/DFGCapabilities.h:88 > + if (mightCompileFunctionForCall(codeBlock)) > + return capabilityLevel(codeBlock); > + if (mightInlineFunctionForCall(codeBlock)) > + return leastUpperBound(CanInline, capabilityLevel(codeBlock)); > + return CannotCompile; We should rearrange this to check both mightCompile/mightInline, then do the CodeBlock capability check accordingly.
Created attachment 230633 [details] Patch
Attachment 230633 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/Options.h:313: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 230634 [details] Patch
Attachment 230634 [details] did not pass style-queue: ERROR: Source/JavaScriptCore/runtime/Options.h:313: enum members should use InterCaps with an initial capital letter. [readability/enum_casing] [4] Total errors found: 1 in 13 files If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 230634 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=230634&action=review r=me > Source/JavaScriptCore/dfg/DFGFunctionWhitelist.cpp:70 > + // Get rid of newlines at the end of the strings. "ends" > Source/JavaScriptCore/dfg/DFGFunctionWhitelist.cpp:73 > + if (line[length-1] == '\n') { > + line[length-1] = '\0'; spacing > Source/JavaScriptCore/dfg/DFGFunctionWhitelist.h:48 > + HashSet<String> m_functionNames; You should call this "entries" or something. It's not just names -- it's whitelist entries, which can be names or hashes or both concatenated.
Committed r168178: <http://trac.webkit.org/changeset/168178>
(In reply to comment #14) > Committed r168178: <http://trac.webkit.org/changeset/168178> This broke the cloop build.
(In reply to comment #15) > (In reply to comment #14) > > Committed r168178: <http://trac.webkit.org/changeset/168178> > > This broke the cloop build. Fix on the way!
*** Bug 131004 has been marked as a duplicate of this bug. ***