WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
132435
[iOS][WK2] The highlight view needs to be in WKWebView coordinates
https://bugs.webkit.org/show_bug.cgi?id=132435
Summary
[iOS][WK2] The highlight view needs to be in WKWebView coordinates
Benjamin Poulain
Reported
2014-05-01 12:36:43 PDT
[iOS][WK2] The highlight view needs to be in WKWebView coordinates
Attachments
Patch
(6.35 KB, patch)
2014-05-01 12:40 PDT
,
Benjamin Poulain
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Benjamin Poulain
Comment 1
2014-05-01 12:40:32 PDT
Created
attachment 230603
[details]
Patch
Tim Horton
Comment 2
2014-05-01 13:25:53 PDT
Comment on
attachment 230603
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=230603&action=review
> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:375 > + RetainPtr<UIColor> highlightUIKitColor = adoptNS([[UIColor alloc] initWithRed:(color.red() / 255.0) green:(color.green() / 255.0) blue:(color.blue() / 255.0) alpha:(color.alpha() / 255.0)]);
We really need something for this in Color or somewhere.
Benjamin Poulain
Comment 3
2014-05-01 13:33:20 PDT
Comment on
attachment 230603
[details]
Patch Clearing flags on attachment: 230603 Committed
r168117
: <
http://trac.webkit.org/changeset/168117
>
Benjamin Poulain
Comment 4
2014-05-01 13:33:22 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug