Currently this generate a NOT_SUPPORTED_ERROR which is wrong per the WebIDL spec
Created attachment 230543 [details] Patch
Comment on attachment 230543 [details] Patch Attachment 230543 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4809378834153472 New failing tests: fast/canvas/canvas-2d-imageData-create-nonfinite.html
Created attachment 230548 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 230560 [details] Patch
Do you have link to the spec?
(In reply to comment #5) > Do you have link to the spec? http://www.w3.org/TR/WebIDL/#es-double
Oh, it is about double.... then the real fix would be to change our WebIDL interpreter. It seems fine to change it in Context2D in the meantime.
Created attachment 230570 [details] Patch
Comment on attachment 230570 [details] Patch submitted by accident
Comment on attachment 230560 [details] Patch Clearing flags on attachment: 230560 Committed r168092: <http://trac.webkit.org/changeset/168092>
All reviewed patches have been landed. Closing bug.
> then the real fix would be to change our WebIDL interpreter. Is there a bug tracking the right fix? It would be helpful to have a FIXME in code referencing the bug, so that we can more easily remove this workaround when it's no longer needed.
(rs=me to add a line with the FIXME)
(In reply to comment #12) > > then the real fix would be to change our WebIDL interpreter. > > Is there a bug tracking the right fix? It would be helpful to have a FIXME in code referencing the bug, so that we can more easily remove this workaround when it's no longer needed. yes, see https://bugs.webkit.org/show_bug.cgi?id=101783 The 'isFinite' testing is all over the codebase. Do you want me to add a todo to just the lines that I touched?
If it's already all over the place, then there is no point indeed.