Bug 132410 - If there are no services available, do not show the service controls UI
Summary: If there are no services available, do not show the service controls UI
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac All
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-30 16:54 PDT by Brady Eidson
Modified: 2014-04-30 18:19 PDT (History)
2 users (show)

See Also:

Attachments
Patch v1 (24.53 KB, patch)
2014-04-30 17:07 PDT, Brady Eidson 		thorton: review+
Details | Formatted Diff | Diff
Patch v2 - Rebased (24.49 KB, patch)
2014-04-30 17:13 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Patch v3 - For landing (24.38 KB, patch)
2014-04-30 17:23 PDT, Brady Eidson 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2014-04-30 16:54:41 PDT 
If there are no services available, do not show the service controls UI

<rdar://problem/16735665>
Comment 1 Brady Eidson 2014-04-30 17:07:16 PDT 
Created attachment 230540 [details]
Patch v1
Comment 2 Tim Horton 2014-04-30 17:12:12 PDT 
Comment on attachment 230540 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=230540&action=review

> Source/WebKit2/Shared/WebProcessCreationParameters.cpp:52
> +    , imageServicesExist(false)

hasImageServices, etc?
Comment 3 Brady Eidson 2014-04-30 17:13:49 PDT 
Created attachment 230541 [details]
Patch v2 - Rebased
Comment 4 Brady Eidson 2014-04-30 17:14:19 PDT 
Will make that change
Comment 5 Brady Eidson 2014-04-30 17:23:37 PDT 
Created attachment 230544 [details]
Patch v3 - For landing
Comment 6 WebKit Commit Bot 2014-04-30 18:19:24 PDT 
Comment on attachment 230544 [details]
Patch v3 - For landing

Clearing flags on attachment: 230544

Committed r168074: <http://trac.webkit.org/changeset/168074>
Comment 7 WebKit Commit Bot 2014-04-30 18:19:26 PDT 
All reviewed patches have been landed.  Closing bug.