Bug 132408 - REGRESSION(r167879): OrderIterator changes caused regressions in flexbox (Requested by rego on #webkit).
Summary: REGRESSION(r167879): OrderIterator changes caused regressions in flexbox (Req...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords:
Depends on:
Blocks: 119061
  Show dependency treegraph
 
Reported: 2014-04-30 16:14 PDT by WebKit Commit Bot
Modified: 2014-04-30 17:14 PDT (History)
7 users (show)

See Also:


Attachments
ROLLOUT of r167879 (14.42 KB, patch)
2014-04-30 16:14 PDT, WebKit Commit Bot
no flags Details | Formatted Diff | Diff
Patch (12.62 KB, patch)
2014-04-30 16:25 PDT, Manuel Rego Casasnovas
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2014-04-30 16:14:24 PDT
http://trac.webkit.org/changeset/167879 broke the build:
OrderIterator changes caused regressions in flexbox (Requested by rego on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2014-04-30 16:14:51 PDT
Created attachment 230533 [details]
ROLLOUT of r167879

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Manuel Rego Casasnovas 2014-04-30 16:19:42 PDT
Comment on attachment 230533 [details]
ROLLOUT of r167879

View in context: https://bugs.webkit.org/attachment.cgi?id=230533&action=review

> LayoutTests/fast/flexbox/order-iterator-crash.html:-1
> -<div>This test has passed if it doesn't crash.</div>

Actually we should keep this test, as it would avoid to introduce similar issues in the future. So, I'm modifying the rollout patch manually.
Comment 3 Manuel Rego Casasnovas 2014-04-30 16:25:54 PDT
Created attachment 230535 [details]
Patch
Comment 4 Manuel Rego Casasnovas 2014-04-30 17:13:47 PDT
Committed r168067: <http://trac.webkit.org/changeset/168067>
Comment 5 Manuel Rego Casasnovas 2014-04-30 17:14:20 PDT
Comment on attachment 230535 [details]
Patch

Clearing flags.