WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
132408
REGRESSION(
r167879
): OrderIterator changes caused regressions in flexbox (Requested by rego on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=132408
Summary
REGRESSION(r167879): OrderIterator changes caused regressions in flexbox (Req...
WebKit Commit Bot
Reported
2014-04-30 16:14:24 PDT
http://trac.webkit.org/changeset/167879
broke the build: OrderIterator changes caused regressions in flexbox (Requested by rego on #webkit). This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
ROLLOUT of r167879
(14.42 KB, patch)
2014-04-30 16:14 PDT
,
WebKit Commit Bot
no flags
Details
Formatted Diff
Diff
Patch
(12.62 KB, patch)
2014-04-30 16:25 PDT
,
Manuel Rego Casasnovas
no flags
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
WebKit Commit Bot
Comment 1
2014-04-30 16:14:51 PDT
Created
attachment 230533
[details]
ROLLOUT of
r167879
Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the rollout will be successful. This process takes approximately 15 minutes. If you would like to land the rollout faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
Manuel Rego Casasnovas
Comment 2
2014-04-30 16:19:42 PDT
Comment on
attachment 230533
[details]
ROLLOUT of
r167879
View in context:
https://bugs.webkit.org/attachment.cgi?id=230533&action=review
> LayoutTests/fast/flexbox/order-iterator-crash.html:-1 > -<div>This test has passed if it doesn't crash.</div>
Actually we should keep this test, as it would avoid to introduce similar issues in the future. So, I'm modifying the rollout patch manually.
Manuel Rego Casasnovas
Comment 3
2014-04-30 16:25:54 PDT
Created
attachment 230535
[details]
Patch
Manuel Rego Casasnovas
Comment 4
2014-04-30 17:13:47 PDT
Committed
r168067
: <
http://trac.webkit.org/changeset/168067
>
Manuel Rego Casasnovas
Comment 5
2014-04-30 17:14:20 PDT
Comment on
attachment 230535
[details]
Patch Clearing flags.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug