WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
132403
Always-visible scrollbars continuously repaint after non-momentum scrollling
https://bugs.webkit.org/show_bug.cgi?id=132403
Summary
Always-visible scrollbars continuously repaint after non-momentum scrollling
Beth Dakin
Reported
2014-04-30 14:25:00 PDT
Always-visible scrollbars continuously repaint after non-momentum scrolling <
rdar://problem/16553878
>
Attachments
Patch
(4.13 KB, patch)
2014-04-30 14:29 PDT
,
Beth Dakin
simon.fraser
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Beth Dakin
Comment 1
2014-04-30 14:29:05 PDT
Created
attachment 230522
[details]
Patch
Simon Fraser (smfr)
Comment 2
2014-04-30 14:47:04 PDT
Comment on
attachment 230522
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=230522&action=review
> Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:143 > + if (m_verticalScrollbarPainter) > + [m_verticalScrollbarPainter setUsePresentationValue:YES]; > + if (m_horizontalScrollbarPainter) > + [m_horizontalScrollbarPainter setUsePresentationValue:YES];
You don't really need the nil checks (messaging nil is OK).
> Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:378 > + if (m_verticalScrollbarPainter && [m_verticalScrollbarPainter shouldUsePresentationValue]) {
Could just be if ([m_verticalScrollbarPainter shouldUsePresentationValue])
> Source/WebCore/page/scrolling/mac/ScrollingTreeScrollingNodeMac.mm:385 > + if (m_horizontalScrollbarPainter && [m_horizontalScrollbarPainter shouldUsePresentationValue]) {
Ditto.
Beth Dakin
Comment 3
2014-04-30 15:06:14 PDT
Fixed! Thanks, Simon!
http://trac.webkit.org/changeset/168049
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug