Bug 132399 – Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Anders Carlsson]

Move the legacy WebKit API into WebKitLegacy.framework and move it inside WebKit.framework

[Anders Carlsson]

Created attachment 230516 [details]
Patch

Comment on attachment 230516 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230516&action=review

> Source/WebCore/ChangeLog:9
> +        Allow linking against WebKitLegacy.

Allow WebKitLegacy to link against WebCore.

> Source/WebKit/WebKit.xcodeproj/project.pbxproj:2118
> +			shellScript = "if [ \"${ACTION}\" = \"build\" -o \"${ACTION}\" = \"install\" -o \"${ACTION}\" = \"installhdrs\" ]; then\n    if [[ ${PLATFORM_NAME} == \"macosx\" ]]; then\n        mkdir -p \"${TARGET_BUILD_DIR}/${PUBLIC_HEADERS_FOLDER_PATH}\"\n    fi\n    mkdir -p \"${TARGET_BUILD_DIR}/${PRIVATE_HEADERS_FOLDER_PATH}\"\n    make -d -C mac/WebKitLegacy -f \"MigrateHeadersFromWebKitLegacy.make\" -j `/usr/sbin/sysctl -n hw.activecpu`\nfi\n";

Please remove the -d option to make.

> Source/WebKit/ios/DefaultDelegates/WebDefaultFrameLoadDelegate.m:30
> -#import <WebKit/WebFrameLoadDelegatePrivate.h>
> +#import <WebKitLegacy/WebFrameLoadDelegatePrivate.h>

We should not use framework-style imports for WebKitLegacy headers from within WebKit source files.

> Source/WebKit/mac/WebKitLegacy/MigrateHeadersFromWebKitLegacy.make:1
> +# Copyright (C) 2006, 2007, 2008 Apple Inc. All rights reserved.

2014

> Source/WebKit/mac/WebKitLegacy/MigrateHeadersFromWebKitLegacy.make:184
> +    WKBackForwardList.h \
> +    WKBackForwardListItem.h \
> +    WKFoundation.h \
> +    WKFrameInfo.h \
> +    WKNavigation.h \
> +    WKNavigationAction.h \
> +    WKNavigationDelegate.h \
> +    WKNavigationResponse.h \
> +    WKPreferences.h \
> +    WKProcessPool.h \
> +    WKScriptMessage.h \
> +    WKScriptMessageHandler.h \
> +    WKUIDelegate.h \
> +    WKUserContentController.h \
> +    WKWebView.h \
> +    WKWebViewConfiguration.h \

These modern API headers don’t belong here.

[Anders Carlsson]

Committed r168047: <http://trac.webkit.org/changeset/168047>