Bug 132393 - Fix PageVisibility on iOS
Summary: Fix PageVisibility on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-30 11:50 PDT by Gavin Barraclough
Modified: 2014-04-30 17:24 PDT (History)
1 user (show)

See Also:


Attachments
Fix (33.93 KB, patch)
2014-04-30 12:12 PDT, Gavin Barraclough
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2014-04-30 11:50:19 PDT
.
Comment 1 Gavin Barraclough 2014-04-30 12:12:42 PDT
Created attachment 230508 [details]
Fix
Comment 2 WebKit Commit Bot 2014-04-30 12:14:10 PDT
Attachment 230508 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/ios/ProcessThrottler.h:48:  The parameter name "throttler" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/ios/ProcessThrottler.h:48:  The parameter name "visibility" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/ios/ProcessThrottler.h:69:  The parameter name "visibility" adds no information, so it should be removed.  [readability/parameter_name] [5]
ERROR: Source/WebKit2/UIProcess/ios/ProcessThrottler.h:99:  An else if statement should be written as an if statement when the prior "if" concludes with a return, break, continue or goto statement.  [readability/control_flow] [4]
Total errors found: 4 in 14 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2014-04-30 12:44:27 PDT
Comment on attachment 230508 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=230508&action=review

r=me

I'd probably out-of-line the ProcessThottler.h stuff since it's included from everywhere in WK2.

> Source/WebKit2/UIProcess/WebProcessProxy.h:138
> +    ProcessThrottler& throttler() { return *m_throttler.get(); }

You don't need the .get() here.

> Source/WebKit2/UIProcess/ios/ProcessAssertion.mm:35
> +const BKSProcessAssertionFlags suspenedTabFlags = (BKSProcessAssertionAllowIdleSleep);

Typo, should be suspendedTabFlags.
Comment 4 Gavin Barraclough 2014-04-30 12:53:08 PDT
Transmitting file data ................
Committed revision 168038.
Comment 5 Gavin Barraclough 2014-04-30 17:24:31 PDT
+ r168069