Bug 132389 - Web Inspector: Ensure UIProcess checks in to webinspectord after spawning a WebProcess
Summary: Web Inspector: Ensure UIProcess checks in to webinspectord after spawning a W...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-30 10:47 PDT by Joseph Pecoraro
Modified: 2019-05-02 20:57 PDT (History)
6 users (show)

See Also:


Attachments
[PATCH] Proposed Fix (1.82 KB, patch)
2014-04-30 10:58 PDT, Joseph Pecoraro
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2014-04-30 10:47:17 PDT
Since we aggregate WebProcess WebViews under the UIProcess, debuggers were expecting the UIProcess to connect. In some situations it was not connecting so the views never showed up. We should always have the UIProcess connect to webinspectord if it is spawning a WebProcess.

<rdar://problem/16676218>
Comment 1 Joseph Pecoraro 2014-04-30 10:58:04 PDT
Created attachment 230495 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2014-04-30 12:29:47 PDT
Comment on attachment 230495 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 230495

Committed r168035: <http://trac.webkit.org/changeset/168035>
Comment 3 WebKit Commit Bot 2014-04-30 12:29:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Basuke Suzuki 2019-05-01 16:55:29 PDT
I cannot understand this patch, but is this XPC related? For WinCairo case, there seems no reason to instanciate RemoteInspector object in UIProcess.
Comment 5 Joseph Pecoraro 2019-05-02 20:57:06 PDT
(In reply to Basuke Suzuki from comment #4)
> I cannot understand this patch, but is this XPC related? For WinCairo case,
> there seems no reason to instanciate RemoteInspector object in UIProcess.

Yes this is XPC related for Cocoa platforms (encourage the UIProcess to connect to webinspectord when it creates a WebContentProcess that may have a page). This could be made PLATFORM(COCOA) if needed.