RESOLVED FIXED 132389
Web Inspector: Ensure UIProcess checks in to webinspectord after spawning a WebProcess
https://bugs.webkit.org/show_bug.cgi?id=132389
Summary Web Inspector: Ensure UIProcess checks in to webinspectord after spawning a W...
Joseph Pecoraro
Reported 2014-04-30 10:47:17 PDT
Since we aggregate WebProcess WebViews under the UIProcess, debuggers were expecting the UIProcess to connect. In some situations it was not connecting so the views never showed up. We should always have the UIProcess connect to webinspectord if it is spawning a WebProcess. <rdar://problem/16676218>
Attachments
[PATCH] Proposed Fix (1.82 KB, patch)
2014-04-30 10:58 PDT, Joseph Pecoraro
no flags
Joseph Pecoraro
Comment 1 2014-04-30 10:58:04 PDT
Created attachment 230495 [details] [PATCH] Proposed Fix
WebKit Commit Bot
Comment 2 2014-04-30 12:29:47 PDT
Comment on attachment 230495 [details] [PATCH] Proposed Fix Clearing flags on attachment: 230495 Committed r168035: <http://trac.webkit.org/changeset/168035>
WebKit Commit Bot
Comment 3 2014-04-30 12:29:50 PDT
All reviewed patches have been landed. Closing bug.
Basuke Suzuki
Comment 4 2019-05-01 16:55:29 PDT
I cannot understand this patch, but is this XPC related? For WinCairo case, there seems no reason to instanciate RemoteInspector object in UIProcess.
Joseph Pecoraro
Comment 5 2019-05-02 20:57:06 PDT
(In reply to Basuke Suzuki from comment #4) > I cannot understand this patch, but is this XPC related? For WinCairo case, > there seems no reason to instanciate RemoteInspector object in UIProcess. Yes this is XPC related for Cocoa platforms (encourage the UIProcess to connect to webinspectord when it creates a WebContentProcess that may have a page). This could be made PLATFORM(COCOA) if needed.
Note You need to log in before you can comment on or make changes to this bug.