Bug 132382 - [CSS Grid Layout] Remove runtime feature
Summary: [CSS Grid Layout] Remove runtime feature
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Manuel Rego Casasnovas
URL:
Keywords:
Depends on:
Blocks: 60731
  Show dependency tree / graph
 
Reported: 2014-04-30 08:16 PDT by Manuel Rego Casasnovas
Modified: 2014-05-07 02:56 PDT (History)
19 users (show)

See Also:

Attachments
Patch (102.66 KB, patch)
2014-04-30 08:19 PDT, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Rebased patch. (102.46 KB, patch)
2014-05-07 01:28 PDT, Manuel Rego Casasnovas 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Manuel Rego Casasnovas 2014-04-30 08:16:44 PDT 
As suggested in webkit-dev (https://lists.webkit.org/pipermail/webkit-dev/2014-April/026489.html) we should remove the CSS Grid Layout runtime feature and use only the compilation flag to disable CSS Grid Layout until it's ready to be shipped.
Comment 1 Manuel Rego Casasnovas 2014-04-30 08:19:00 PDT 
Created attachment 230478 [details]
Patch
Comment 2 WebKit Commit Bot 2014-04-30 08:20:41 PDT 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Benjamin Poulain 2014-05-05 15:24:31 PDT 
Comment on attachment 230478 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230478&action=review

That's actually a quite nice cleanup.

> Source/WebCore/WebCore.order:-4327
> -__ZNK7WebCore8Document20cssGridLayoutEnabledEv

You actually don't need to update the order files, we update them ourself from the binary before releasing.
Comment 4 WebKit Commit Bot 2014-05-06 02:48:54 PDT 
Comment on attachment 230478 [details]
Patch

Rejecting attachment 230478 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 230478, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
ss3/grid/grid-column-002.htm
patching file LayoutTests/ietestcenter/css3/grid/testRunnerEnableGrid.js
rm 'LayoutTests/ietestcenter/css3/grid/testRunnerEnableGrid.js'
patching file PerformanceTests/ChangeLog
patching file PerformanceTests/Layout/auto-grid-lots-of-data.html
patching file PerformanceTests/Layout/fixed-grid-lots-of-data.html

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force', '--reviewer', u'Benjamin Poulain']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: http://webkit-queues.appspot.com/results/5260031767347200
Comment 5 Manuel Rego Casasnovas 2014-05-07 01:28:57 PDT 
Created attachment 230977 [details]
Rebased patch.
Comment 6 WebKit Commit Bot 2014-05-07 02:56:48 PDT 
Comment on attachment 230977 [details]
Rebased patch.

Clearing flags on attachment: 230977

Committed r168416: <http://trac.webkit.org/changeset/168416>
Comment 7 WebKit Commit Bot 2014-05-07 02:56:53 PDT 
All reviewed patches have been landed.  Closing bug.