Bug 132374 - [iOS] do not pause video when entering background while playing to external device
Summary: [iOS] do not pause video when entering background while playing to external d...
Status: ASSIGNED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Eric Carlson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-29 20:41 PDT by Eric Carlson
Modified: 2014-04-30 18:48 PDT (History)
9 users (show)

See Also:


Attachments
Proposed patch. (11.57 KB, patch)
2014-04-29 20:50 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff
Updated patch. (11.56 KB, patch)
2014-04-30 09:51 PDT, Eric Carlson
jer.noble: review+
Details | Formatted Diff | Diff
Another patch (12.92 KB, patch)
2014-04-30 15:09 PDT, Eric Carlson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2014-04-29 20:41:23 PDT
Do not pause <video>/<audio> when process switches to background while playing to an external device.
Comment 1 Eric Carlson 2014-04-29 20:41:56 PDT
<rdar://problem/16630465>
Comment 2 Eric Carlson 2014-04-29 20:50:18 PDT
Created attachment 230454 [details]
Proposed patch.
Comment 3 Eric Carlson 2014-04-30 09:51:56 PDT
Created attachment 230485 [details]
Updated patch.
Comment 4 Jer Noble 2014-04-30 14:44:46 PDT
Comment on attachment 230485 [details]
Updated patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=230485&action=review

> Source/WebCore/platform/audio/MediaSession.cpp:85
> +    if (type == EnteringBackground && client().overrideBackgroundPlaybackRestriction())
> +        return;
> +

I'm not a huge fan of making the client responsible for this behavior, but I don't think we have a choice right now.  r=me.
Comment 5 Eric Carlson 2014-04-30 15:09:39 PDT
Created attachment 230528 [details]
Another patch 

To get the managed name of beginInterruption for the Windows export file.
Comment 6 Eric Carlson 2014-04-30 18:48:52 PDT
Committed r168075: https://trac.webkit.org/r168075