Bug 132367 - update angle
Summary: update angle
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: ANGLE (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-29 16:30 PDT by Alex Christensen
Modified: 2014-04-30 15:58 PDT (History)
13 users (show)

See Also:

Attachments
Patch (2.96 MB, patch)
2014-04-29 17:23 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (2.95 MB, patch)
2014-04-30 09:29 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (2.96 MB, patch)
2014-04-30 09:55 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
Patch (2.88 MB, patch)
2014-04-30 10:05 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
patch (2.88 MB, patch)
2014-04-30 10:29 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
patch (2.88 MB, patch)
2014-04-30 10:59 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
patch (2.86 MB, patch)
2014-04-30 11:11 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
patch (2.86 MB, patch)
2014-04-30 11:41 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
patch (2.86 MB, patch)
2014-04-30 11:54 PDT, Alex Christensen 		no flags Details | Formatted Diff | Diff
patch (2.86 MB, patch)
2014-04-30 12:47 PDT, Alex Christensen 		dino: review+
Details | Formatted Diff | Diff
patch (2.86 MB, patch)
2014-04-30 14:08 PDT, Alex Christensen 		dino: review+
commit-queue: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (10) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2014-04-29 16:30:42 PDT 
I updated angle.  I also think it would be good to include a diff from angle so we can see and manage our changes.
Comment 1 Alex Christensen 2014-04-29 17:23:27 PDT 
Created attachment 230443 [details]
Patch
Comment 2 WebKit Commit Bot 2014-04-29 17:26:29 PDT 
Note that there are important steps to take when updating ANGLE. See http://trac.webkit.org/wiki/UpdatingANGLE
Comment 3 Alex Christensen 2014-04-29 18:00:35 PDT 
Comment on attachment 230443 [details]
Patch

I forgot Roger's changes from https://bugs.webkit.org/show_bug.cgi?id=125124
Comment 4 Alex Christensen 2014-04-30 09:29:29 PDT 
Created attachment 230484 [details]
Patch
Comment 5 Alex Christensen 2014-04-30 09:55:52 PDT 
Created attachment 230486 [details]
Patch
Comment 6 Alex Christensen 2014-04-30 10:05:23 PDT 
Created attachment 230487 [details]
Patch
Comment 7 Alex Christensen 2014-04-30 10:29:35 PDT 
Created attachment 230490 [details]
patch
Comment 8 Alex Christensen 2014-04-30 10:59:01 PDT 
Created attachment 230496 [details]
patch
Comment 9 Alex Christensen 2014-04-30 11:11:04 PDT 
Created attachment 230497 [details]
patch
Comment 10 Alex Christensen 2014-04-30 11:41:25 PDT 
Created attachment 230502 [details]
patch
Comment 11 Alex Christensen 2014-04-30 11:54:08 PDT 
Created attachment 230505 [details]
patch
Comment 12 Alex Christensen 2014-04-30 12:47:11 PDT 
Created attachment 230510 [details]
patch
Comment 13 Dean Jackson 2014-04-30 13:33:50 PDT 
Writing comments here because the review tool is unhappy with me:

- Please add a link to <rdar://problem/16211451> in the changelog
- Don't remove <array> in the plist. That file is used by some automatic process in Apple's system (I don't know how), so we can't change the format

This also needs the WebKit-specific changes made in http://trac.webkit.org/changeset/164580

Lastly, please confirm that http://trac.webkit.org/changeset/160199 is now covered in the updated code.
Comment 14 Alex Christensen 2014-04-30 14:08:27 PDT 
Created attachment 230518 [details]
patch
Comment 15 Alex Christensen 2014-04-30 14:18:23 PDT 
(In reply to comment #13)
> Writing comments here because the review tool is unhappy with me:
> 
> - Please add a link to <rdar://problem/16211451> in the changelog
Done.
> - Don't remove <array> in the plist. That file is used by some automatic process in Apple's system (I don't know how), so we can't change the format
Fixed.
> 
> This also needs the WebKit-specific changes made in http://trac.webkit.org/changeset/164580
ANGLE has made some changes to src/libGLESv2/Program.cpp so I adapted to their changes.  My changes can be seen in changes.diff.  No WebKit ports are using that file right now, though, so it shouldn't change anything.
> 
> Lastly, please confirm that http://trac.webkit.org/changeset/160199 is now covered in the updated code.
It already was.
Comment 16 WebKit Commit Bot 2014-04-30 15:23:24 PDT 
Comment on attachment 230518 [details]
patch

Rejecting attachment 230518 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'land-attachment', '--force-clean', '--non-interactive', '--parent-command=commit-queue', 230518, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
e921d3d8e646e3b38c54c29ffa38d4d5708
r168046 = 860937fc8fe1f954dcd824171c859fbafa1176c2
r168047 = 2201dc7ef9dfc80fe6ae593eafd6c68f590c674b
r168048 = db1671a2aa4338701457b6f2445c6230c72ae2da
r168049 = 199e402b648e7bf69927624b7c76a5a92bf90ed6
r168050 = df40d6e0f374ac7e4269537464c26e066023161b
Done rebuilding .git/svn/refs/remotes/origin/master/.rev_map.268f45cc-cd09-0410-ab3c-d52691b4dbfc
First, rewinding head to replay your work on top of it...
Fast-forwarded master to refs/remotes/origin/master.

Full output: http://webkit-queues.appspot.com/results/5069287706329088
Comment 17 Alex Christensen 2014-04-30 15:58:34 PDT 
http://trac.webkit.org/changeset/168055