Bug 132334 - Merge same ifdef blocks into each other
Summary: Merge same ifdef blocks into each other
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-29 05:48 PDT by Zsolt Borbely
Modified: 2014-04-30 02:33 PDT (History)
0 users

See Also:

Attachments
Proposed patch (2.45 KB, patch)
2014-04-29 05:51 PDT, Zsolt Borbely 		darin: review-
darin: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zsolt Borbely 2014-04-29 05:48:33 PDT 
Merge same ifdef blocks into each other.
Comment 1 Zsolt Borbely 2014-04-29 05:51:27 PDT 
Created attachment 230368 [details]
Proposed patch
Comment 2 Darin Adler 2014-04-29 09:16:45 PDT 
Comment on attachment 230368 [details]
Proposed patch

I don’t think this is a good idea. It’s better to have a separate #if for the includes and for things inside this file.