Bug 132331 - Build warning in source/JavaScriptCore/dfg/DFGFixupPhase.cpp
Summary: Build warning in source/JavaScriptCore/dfg/DFGFixupPhase.cpp
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-29 04:32 PDT by Tanay
Modified: 2014-05-09 11:21 PDT (History)
4 users (show)

See Also:

Attachments
Patch for build warning fix (1.94 KB, patch)
2014-05-05 23:02 PDT, Tanay 		no flags Details | Formatted Diff | Diff
Patch (2.21 KB, patch)
2014-05-07 05:06 PDT, Tanay 		no flags Details | Formatted Diff | Diff
Patch (2.03 KB, patch)
2014-05-07 22:06 PDT, Tanay 		no flags Details | Formatted Diff | Diff
Patch (2.01 KB, patch)
2014-05-08 22:24 PDT, Tanay 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tanay 2014-04-29 04:32:44 PDT 
In file included from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGAdjacencyList.h:32:0,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGNode.h:33,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGBasicBlock.h:35,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGGraph.h:34,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:31:
/home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGEdge.h: In member function ‘void JSC::DFG::FixupPhase::injectTypeConversionsForEdge(JSC::DFG::Node*, JSC::DFG::Edge&)’:
/home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGEdge.h:64:22: warning: ‘result’ may be used uninitialized in this function [-Wmaybe-uninitialized]
/home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1898:19: note: ‘result’ was declared here
In file included from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGAdjacencyList.h:32:0,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGNode.h:33,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGBasicBlock.h:35,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGGraph.h:34,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:31:
/home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGEdge.h: In member function ‘void JSC::DFG::FixupPhase::injectTypeConversionsInBlock(JSC::DFG::BasicBlock*)’:
/home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGEdge.h:64:22: warning: ‘result’ may be used uninitialized in this function [-Wmaybe-uninitialized]
/home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1898:19: note: ‘result’ was declared here
In file included from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGAdjacencyList.h:32:0,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGNode.h:33,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGBasicBlock.h:35,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGGraph.h:34,
                 from /home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:31:
/home/tanay.c/webkit/Source/JavaScriptCore/dfg/DFGEdge.h:64:22: warning: ‘result’ may be used uninitialized in this function [-Wmaybe-uninitialized]
Comment 1 Tanay 2014-05-05 23:02:01 PDT 
Created attachment 230889 [details]
Patch for build warning fix

Patch to Fix build warning and coding style warning in DFGFixupPhase.cpp
Comment 2 Filip Pizlo 2014-05-05 23:21:45 PDT 
Comment on attachment 230889 [details]
Patch for build warning fix

Looks like you need to rebase.
Comment 3 Tanay 2014-05-06 04:50:56 PDT 
(In reply to comment #2)
> (From update of attachment 230889 [details])
> Looks like you need to rebase.
 
Rebased to r168352. Can still see the warning. Could you please let me know if I am missing some information?
Comment 4 Filip Pizlo 2014-05-06 06:54:01 PDT 
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 230889 [details] [details])
> > Looks like you need to rebase.
> 
> Rebased to r168352. Can still see the warning. Could you please let me know if I am missing some information?

What I mean is, can you upload a debased patch?
Comment 5 Tanay 2014-05-07 05:06:17 PDT 
Created attachment 230990 [details]
Patch
Comment 6 Filip Pizlo 2014-05-07 07:33:27 PDT 
Comment on attachment 230990 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230990&action=review

> Source/JavaScriptCore/ChangeLog:93
> +>>>>>>> .r168416

You should remove the conflict markets.
Comment 7 Tanay 2014-05-07 22:06:45 PDT 
Created attachment 231046 [details]
Patch
Comment 8 Darin Adler 2014-05-08 12:33:07 PDT 
Comment on attachment 231046 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=231046&action=review

> Source/JavaScriptCore/dfg/DFGFixupPhase.cpp:1868
> +        Node* result = 0;

Please use nullptr instead of 0.
Comment 9 Tanay 2014-05-08 22:24:10 PDT 
Created attachment 231130 [details]
Patch
Comment 10 WebKit Commit Bot 2014-05-09 11:21:08 PDT 
Comment on attachment 231130 [details]
Patch

Clearing flags on attachment: 231130

Committed r168540: <http://trac.webkit.org/changeset/168540>
Comment 11 WebKit Commit Bot 2014-05-09 11:21:11 PDT 
All reviewed patches have been landed.  Closing bug.