Bug 132315 - REGRESSION(r153142) ASSERT from CodeBlock::dumpBytecode dumping nString Switch Jump Tables
Summary: REGRESSION(r153142) ASSERT from CodeBlock::dumpBytecode dumping nString Switc...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-28 17:43 PDT by Michael Saboff
Modified: 2014-04-28 18:36 PDT (History)
0 users

See Also:

Attachments
Patch (1.70 KB, patch)
2014-04-28 17:50 PDT, Michael Saboff 		mhahnenberg: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2014-04-28 17:43:06 PDT 
We try to create a String from a RefPtr<StringImp> which will cause a ref.  r153142 added an ASSERT that we aren't on the compilation thread.  dumpBytecode() is probably only called from the compilation thread.
Comment 1 Michael Saboff 2014-04-28 17:50:49 PDT 
Created attachment 230343 [details]
Patch
Comment 2 Mark Hahnenberg 2014-04-28 18:10:36 PDT 
Comment on attachment 230343 [details]
Patch

r=me
Comment 3 Michael Saboff 2014-04-28 18:36:47 PDT 
Committed r167917: <http://trac.webkit.org/changeset/167917>