Bug 132309 – Scrollbars do not update properly when topContentInset changes dynamically

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[Beth Dakin]

Scrollbars do not update properly when topContentInset changes dynamically.

<rdar://problem/16642232>

[Beth Dakin]

Created attachment 230331 [details]
Patch

[Tim Horton]

Comment on attachment 230331 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230331&action=review

> Source/WebCore/page/FrameView.cpp:962
> +    // To fully update scrollbars, we need to call both updateScrolbars() and frameViewDidChangeSize() which will
> +    // will update all of the scrolling-related layers.

I don't think the comment is necessary.

> Source/WebCore/page/FrameView.cpp:964
> +    if (RenderView* renderView = this->renderView()) {

We already have a local and already early returned for RenderView.

[Beth Dakin]

Thank you! http://trac.webkit.org/changeset/167911

[Ryosuke Niwa]

Looks like this regressed PLT by ~2%

[Beth Dakin]

(In reply to comment #4)
> Looks like this regressed PLT by ~2%

This seems very unlikely…

[Ryosuke Niwa]

(In reply to comment #5)
> (In reply to comment #4)
> > Looks like this regressed PLT by ~2%
> 
> This seems very unlikely…

Yeah, looks like it was a temporary fluke.  The numbers look better now.