Bug 132292 - [GTK] install-dependencies should also install ruby-json and ruby-highline
Summary: [GTK] install-dependencies should also install ruby-json and ruby-highline
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-28 11:30 PDT by Carlos Alberto Lopez Perez
Modified: 2014-04-28 13:40 PDT (History)
4 users (show)

See Also:


Attachments
Patch (1.49 KB, patch)
2014-04-28 11:33 PDT, Carlos Alberto Lopez Perez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Alberto Lopez Perez 2014-04-28 11:30:00 PDT
When running the run-jsc-stress-tests test suite, the following warnings are shown:

[....]
Running simple version of profiler-test.yaml/tests/sunspider-1.0/string-unpack-code.js because some required Ruby features are unavailable.
Running simple version of profiler-test.yaml/tests/sunspider-1.0/crypto-sha1.js because some required Ruby features are unavailable.
Running simple version of profiler-test.yaml/tests/sunspider-1.0/crypto-md5.js because some required Ruby features are unavailable.
Running simple version of profiler-test.yaml/tests/sunspider-1.0/access-nbody.js because some required Ruby features are unavailable.
Running simple version of profiler-test.yaml/tests/sunspider-1.0/controlflow-recursive.js because some required Ruby features are unavailable.
Running simple version of profiler-test.yaml/tests/sunspider-1.0/access-nsieve.js because some required Ruby features are unavailable.
Running simple version of profiler-test.yaml/tests/sunspider-1.0/3d-raytrace.js because some required Ruby features are unavailable.
[....]

This gets fixed by installing ruby json and highline packages.
Comment 1 Carlos Alberto Lopez Perez 2014-04-28 11:33:49 PDT
Created attachment 230313 [details]
Patch
Comment 2 Philippe Normand 2014-04-28 13:09:25 PDT
Comment on attachment 230313 [details]
Patch

Nice catch, Carlos!
Comment 3 WebKit Commit Bot 2014-04-28 13:40:25 PDT
Comment on attachment 230313 [details]
Patch

Clearing flags on attachment: 230313

Committed r167902: <http://trac.webkit.org/changeset/167902>
Comment 4 WebKit Commit Bot 2014-04-28 13:40:29 PDT
All reviewed patches have been landed.  Closing bug.