Bug 132287 - Build failure in RenderFlowThread.cpp when building release with ASSERT_WITH_SECURITY_IMPLICATION
Summary: Build failure in RenderFlowThread.cpp when building release with ASSERT_WITH_...
Status: RESOLVED DUPLICATE of bug 132290
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-28 10:46 PDT by Drew Yao
Modified: 2014-04-28 11:18 PDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Drew Yao 2014-04-28 10:46:19 PDT 
When building a release build of WebKit with ASSERT_WITH_SECURITY_IMPLICATION enabled, I'm getting a build error

/Volumes/data_apps/WebKit/Source/WebCore/rendering/RenderFlowThread.cpp:606:38: error: use of undeclared
      identifier 'checkLinesConsistency'
    ASSERT_WITH_SECURITY_IMPLICATION(checkLinesConsistency(blockFlow));

http://trac.webkit.org/changeset/167871
added the assert.

In RenderFlowThread.cpp, RenderFlowThread::checkLinesConsistency and other functions are defined inside a #ifndef NDEBUG.

Instead, it should be 
#if !ASSERT_WITH_SECURITY_IMPLICATION_DISABLED 

By default, the behavior will be the same, but this will fix the build for release + ASSERT_WITH_SECURITY_IMPLICATION.

See http://trac.webkit.org/changeset/160462 for an example of a similar change.
Comment 1 David Kilzer (:ddkilzer) 2014-04-28 11:18:49 PDT 
This patch was rolled out for a separate reason by Bug 132290, so duping to that.

*** This bug has been marked as a duplicate of bug 132290 ***