RESOLVED DUPLICATE of bug 132290132287
Build failure in RenderFlowThread.cpp when building release with ASSERT_WITH_SECURITY_IMPLICATION 
https://bugs.webkit.org/show_bug.cgi?id=132287
Summary Build failure in RenderFlowThread.cpp when building release with ASSERT_WITH_...
Drew Yao
Reported 2014-04-28 10:46:19 PDT
When building a release build of WebKit with ASSERT_WITH_SECURITY_IMPLICATION enabled, I'm getting a build error /Volumes/data_apps/WebKit/Source/WebCore/rendering/RenderFlowThread.cpp:606:38: error: use of undeclared identifier 'checkLinesConsistency' ASSERT_WITH_SECURITY_IMPLICATION(checkLinesConsistency(blockFlow)); http://trac.webkit.org/changeset/167871 added the assert. In RenderFlowThread.cpp, RenderFlowThread::checkLinesConsistency and other functions are defined inside a #ifndef NDEBUG. Instead, it should be #if !ASSERT_WITH_SECURITY_IMPLICATION_DISABLED By default, the behavior will be the same, but this will fix the build for release + ASSERT_WITH_SECURITY_IMPLICATION. See http://trac.webkit.org/changeset/160462 for an example of a similar change.
Attachments
Add attachment proposed patch, testcase, etc.
David Kilzer (:ddkilzer)
Comment 1 2014-04-28 11:18:49 PDT
This patch was rolled out for a separate reason by Bug 132290, so duping to that. *** This bug has been marked as a duplicate of bug 132290 ***
Note You need to log in before you can comment on or make changes to this bug.