Bug 132248 – [GTK] Some media fragment tests are flaky

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Xabier Rodríguez Calvar]

media/media-fragments/TC0078.html [ Failure Pass ]
media/media-fragments/TC0086.html [ Failure Pass ]

[Xabier Rodríguez Calvar]

Added

media/media-fragments/TC0037.html [ Failure Pass ]
media/media-fragments/TC0085.html [ Failure Pass ]
media/media-fragments/TC0091.html [ Failure Pass ]

[Carlos Alberto Lopez Perez]

I'm adding this on the test expectation for this bug:

  media/media-fragments/TC0001.html [ Timeout Pass ]
  media/media-fragments/TC0002.html [ Crash ]
  media/media-fragments/TC0014.html [ Failure Pass ]
  media/media-fragments/TC0015.html [ Crash ]
  media/media-fragments/TC0015.html [ Failure Pass ]
  media/media-fragments/TC0038.html [ Crash ]
  media/media-fragments/TC0085.html [ Crash ]
  media/media-fragments/TC0086.html [ Failure Timeout Pass ]
  media/media-fragments/TC0087.html [ Timeout Pass ]
  media/media-fragments/TC0088.html [ Crash ]
  media/media-fragments/TC0090.html [ Failure Pass ]

[Carlos Alberto Lopez Perez]

Sorry: for the [ Crash ] ones, it really is [ Crash Pass ]
(only crashes sometimes)

[Marcos Chavarría Teijeiro (irc: chavaone)]

Adding the following test which timeout sometimes:

 media/media-fragments/TC0055.html [ Failure Pass Timeout ]
 media/media-fragments/TC0058.html [ Timeout Pass ]

[Marcos Chavarría Teijeiro (irc: chavaone)]

Added:
media/media-fragments/TC0063.html [ Timeout Pass ]

[Marcos Chavarría Teijeiro (irc: chavaone)]

media/media-fragments/TC0061.html [ Timeout Pass ]
media/media-fragments/TC0067.html [ Timeout Pass ]
media/media-fragments/TC0080.html [ Timeout Pass ]

[Marcos Chavarría Teijeiro (irc: chavaone)]

*** Bug 143709 has been marked as a duplicate of this bug. ***

[Marcos Chavarría Teijeiro (irc: chavaone)]

media/media-fragments/TC0065.html [ Timeout Pass ]
media/media-fragments/TC0066.html [ Timeout Pass ]
media/media-fragments/TC0068.html [ Timeout Pass ]
media/media-fragments/TC0081.html [ Timeout Pass ]

Updating test expectations on bug #145166.

[Miguel Gomez]

media/media-fragments/TC0004.html [ Timeout Crash Pass ]
media/media-fragments/TC0017.html [ Timeout Pass ]

[Charlie Turner]

Created attachment 373640 [details]
Patch

[Charlie Turner]

CC Eric, do you think this stop time is OK? On Mac/iOS, looks like Apple is seeing a stddev > 0.5 as well, see https://bugs.webkit.org/show_bug.cgi?id=187522#c4

[Eric Carlson]

(In reply to Charlie Turner from comment #11)
> CC Eric, do you think this stop time is OK? On Mac/iOS, looks like Apple is
> seeing a stddev > 0.5 as well, see
> https://bugs.webkit.org/show_bug.cgi?id=187522#c4

@ cturner - this seems fine, thanks for the fix!

[Charlie Turner]

Created attachment 373659 [details]
Patch for landing

[Charlie Turner]

Ta Eric!

[WebKit Commit Bot]

Comment on attachment 373659 [details]
Patch for landing

Rejecting attachment 373659 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.webkit.org', '--bot-id=webkit-cq-02', 'apply-attachment', '--no-update', '--non-interactive', 373659, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Logging in as [e-mail]...
Fetching: https://bugs.webkit.org/attachment.cgi?id=373659&action=edit
Fetching: https://bugs.webkit.org/show_bug.cgi?id=132248&ctype=xml&excludefield=attachmentdata
Processing 1 patch from 1 bug.
Processing patch 373659 from bug 132248.
Fetching: https://bugs.webkit.org/attachment.cgi?id=373659
Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Parsed 38 diffs from patch file(s).
patching file Source/WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp
Hunk #1 FAILED at 156.
Hunk #2 FAILED at 261.
Hunk #3 FAILED at 363.
Hunk #4 succeeded at 510 with fuzz 2 (offset 7 lines).
Hunk #5 FAILED at 604.
Hunk #6 FAILED at 616.
Hunk #7 FAILED at 634.
6 out of 7 hunks FAILED -- saving rejects to file Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp.rej
patching file Tools/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file Tools/gstreamer/jhbuild.modules
Hunk #1 FAILED at 92.
1 out of 1 hunk FAILED -- saving rejects to file Tools/gstreamer/jhbuild.modules.rej
patching file Tools/gstreamer/patches/gst-plugins-bad-do-not-retry-downloads-during-shutdown.patch
patching file LayoutTests/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file LayoutTests/media/media-fragments/TC0004-expected.txt
patching file LayoutTests/media/media-fragments/TC0005-expected.txt
patching file LayoutTests/media/media-fragments/TC0006-expected.txt
patching file LayoutTests/media/media-fragments/TC0011-expected.txt
patching file LayoutTests/media/media-fragments/TC0015-expected.txt
patching file LayoutTests/media/media-fragments/TC0017-expected.txt
patching file LayoutTests/media/media-fragments/TC0024-expected.txt
patching file LayoutTests/media/media-fragments/TC0035-expected.txt
patching file LayoutTests/media/media-fragments/TC0036-expected.txt
patching file LayoutTests/media/media-fragments/TC0037-expected.txt
patching file LayoutTests/media/media-fragments/TC0038-expected.txt
patching file LayoutTests/media/media-fragments/TC0039-expected.txt
patching file LayoutTests/media/media-fragments/TC0051-expected.txt
patching file LayoutTests/media/media-fragments/TC0052-expected.txt
patching file LayoutTests/media/media-fragments/TC0053-expected.txt
patching file LayoutTests/media/media-fragments/TC0054-expected.txt
patching file LayoutTests/media/media-fragments/TC0055-expected.txt
patching file LayoutTests/media/media-fragments/TC0059-expected.txt
patching file LayoutTests/media/media-fragments/TC0072-expected.txt
patching file LayoutTests/media/media-fragments/TC0078-expected.txt
patching file LayoutTests/media/media-fragments/TC0079-expected.txt
patching file LayoutTests/media/media-fragments/TC0080-expected.txt
patching file LayoutTests/media/media-fragments/TC0081-expected.txt
patching file LayoutTests/media/media-fragments/TC0085-expected.txt
patching file LayoutTests/media/media-fragments/TC0086-expected.txt
patching file LayoutTests/media/media-fragments/TC0087-expected.txt
patching file LayoutTests/media/media-fragments/TC0088-expected.txt
patching file LayoutTests/media/media-fragments/TC0089-expected.txt
patching file LayoutTests/media/media-fragments/TC0090-expected.txt
patching file LayoutTests/media/media-fragments/TC0091-expected.txt
patching file LayoutTests/media/media-fragments/media-fragments.js
patching file LayoutTests/platform/gtk/TestExpectations

Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit

Full output: https://webkit-queues.webkit.org/results/12692102

[Charlie Turner]

Created attachment 373660 [details]
Patch for landing

[WebKit Commit Bot]

Comment on attachment 373660 [details]
Patch for landing

Clearing flags on attachment: 373660

Committed r247229: <https://trac.webkit.org/changeset/247229>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.