Bug 132244 - [GTK][cmake] CMake variable (non)expansion causing 'File name too long' build error.
Summary: [GTK][cmake] CMake variable (non)expansion causing 'File name too long' build...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nikos Andronikos
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-27 23:27 PDT by Nikos Andronikos
Modified: 2014-04-29 18:54 PDT (History)
8 users (show)

See Also:


Attachments
'File name too long' error example (9.82 KB, application/octet-stream)
2014-04-27 23:27 PDT, Nikos Andronikos
no flags Details
Patch (1.31 KB, patch)
2014-04-28 00:55 PDT, Nikos Andronikos
no flags Details | Formatted Diff | Diff
Patch (1.34 KB, patch)
2014-04-29 17:59 PDT, Nikos Andronikos
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikos Andronikos 2014-04-27 23:27:29 PDT
Created attachment 230282 [details]
'File name too long' error example

Whilst trying to build the WebKit GTK version using the command:
./Tools/Scripts/build-webkit --gtk

I am encountering a 'File name too long' error in multiple places (please see attachment for example of error output).  

As far as I know the WebKit GTK buildbot builds do not seem to be having this problem.

Some details of my machine configuration:
Architecture: x86_64
Linux Distribution: Ubuntu 12.04
GCC/G++ version: 4.8
CMake version: 2.8.7
Comment 1 Nikos Andronikos 2014-04-28 00:55:43 PDT
Created attachment 230284 [details]
Patch
Comment 2 Raphael Kubo da Costa (:rakuco) 2014-04-28 03:29:11 PDT
Interesting. The bug fix/behaviour change was introduced between CMake 2.8.7 and 2.8.8 in http://cmake.org/gitweb?p=cmake.git;a=commit;h=8adaee2b0b2651cfd93bb4a915d11bdd4cba1b51.

I don't see a problem with this patch if we plan on supporting CMake 2.8.7 for a long time. I'd guess there are other places where we are passing lists to INCLUDE_DIRECTORIES(), have you checked that?
Comment 3 Nikos Andronikos 2014-04-28 17:55:48 PDT
(In reply to comment #2)
> Interesting. The bug fix/behaviour change was introduced between CMake 2.8.7 and 2.8.8 in http://cmake.org/gitweb?p=cmake.git;a=commit;h=8adaee2b0b2651cfd93bb4a915d11bdd4cba1b51.
> 
> I don't see a problem with this patch if we plan on supporting CMake 2.8.7 for a long time. I'd guess there are other places where we are passing lists to INCLUDE_DIRECTORIES(), have you checked that?


I just checked - I cant see any other occurrences of lists passed to INCLUDE_DIRECTORIES() in quotes.
Comment 4 Raphael Kubo da Costa (:rakuco) 2014-04-29 01:07:19 PDT
Cool, thanks for checking. Looks good from my side.
Comment 5 Philippe Normand 2014-04-29 01:11:25 PDT
Comment on attachment 230284 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230284&action=review

> Source/WebCore/ChangeLog:5
> +        Removing quotes around include directory variable ${WebCore_INCLUDE_DIRECTORIES} in
> +        the include_directories cmake macro enables the variable to be expanded correctly.

Can you please move these 2 lines below the "Reviewed by" one?
Comment 6 Martin Robinson 2014-04-29 07:32:44 PDT
Comment on attachment 230284 [details]
Patch

Nice fix!
Comment 7 Nikos Andronikos 2014-04-29 17:59:48 PDT
Created attachment 230447 [details]
Patch
Comment 8 Nikos Andronikos 2014-04-29 18:12:06 PDT
(In reply to comment #5)
> (From update of attachment 230284 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=230284&action=review
> 
> > Source/WebCore/ChangeLog:5
> > +        Removing quotes around include directory variable ${WebCore_INCLUDE_DIRECTORIES} in
> > +        the include_directories cmake macro enables the variable to be expanded correctly.
> 
> Can you please move these 2 lines below the "Reviewed by" one?

Done.
Comment 9 Nikos Andronikos 2014-04-29 18:12:23 PDT
(In reply to comment #6)
> (From update of attachment 230284 [details])
> Nice fix!

Thanks.
Comment 10 WebKit Commit Bot 2014-04-29 18:54:24 PDT
Comment on attachment 230447 [details]
Patch

Clearing flags on attachment: 230447

Committed r167976: <http://trac.webkit.org/changeset/167976>
Comment 11 WebKit Commit Bot 2014-04-29 18:54:29 PDT
All reviewed patches have been landed.  Closing bug.