Bug 132223 - [Cocoa] -[WKWebProcessPlugInController parameters] returns nil if no parameters have been set yet
Summary: [Cocoa] -[WKWebProcessPlugInController parameters] returns nil if no paramete...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: mitz
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2014-04-26 18:53 PDT by mitz
Modified: 2014-04-27 16:13 PDT (History)
0 users

See Also:


Attachments
Create m_bundleParameters if needed (1.52 KB, patch)
2014-04-26 18:54 PDT, mitz
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description mitz 2014-04-26 18:53:28 PDT
[Cocoa] -[WKWebProcessPlugInController parameters] returns nil if no parameters have been set yet
Comment 1 mitz 2014-04-26 18:54:57 PDT
Created attachment 230249 [details]
Create m_bundleParameters if needed
Comment 2 Sam Weinig 2014-04-27 15:45:48 PDT
Comment on attachment 230249 [details]
Create m_bundleParameters if needed

View in context: https://bugs.webkit.org/attachment.cgi?id=230249&action=review

> Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:137
> +        m_bundleParameters = adoptNS([[WKWebProcessBundleParameters alloc] initWithDictionary:[NSDictionary dictionary]]);

Maybe @{ } instead of [NSDictionary dictionary]?
Comment 3 mitz 2014-04-27 16:13:50 PDT
(In reply to comment #2)
> (From update of attachment 230249 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=230249&action=review
> 
> > Source/WebKit2/WebProcess/InjectedBundle/mac/InjectedBundleMac.mm:137
> > +        m_bundleParameters = adoptNS([[WKWebProcessBundleParameters alloc] initWithDictionary:[NSDictionary dictionary]]);
> 
> Maybe @{ } instead of [NSDictionary dictionary]?

Done.

Fixed in <http://trac.webkit.org/r167865>.