Bug 132205 - Web Inspector: DOM Tree debugger popover obscures dashboard
Summary: Web Inspector: DOM Tree debugger popover obscures dashboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2014-04-25 14:34 PDT by Jonathan Wells
Modified: 2014-04-26 01:54 PDT (History)
5 users (show)

See Also:


Attachments
[PATCH] Proposed Fix: Change to DashboardContainerView.css (1.27 KB, patch)
2014-04-25 14:43 PDT, Jonathan Wells
no flags Details | Formatted Diff | Diff
[PATCH] Proposed Fix: Change to DashboardContainerView.css, Popover.css (1.71 KB, patch)
2014-04-25 15:17 PDT, Jonathan Wells
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Wells 2014-04-25 14:34:03 PDT
<rdar://problem/16622125>
Comment 1 Jonathan Wells 2014-04-25 14:35:16 PDT
This is a z-index issue. I think this selector in DashboardContainerView.css isn't needed:

.toolbar .dashboard.visible {
    z-index: 100;
}
Comment 2 Jonathan Wells 2014-04-25 14:43:35 PDT
Created attachment 230207 [details]
[PATCH] Proposed Fix: Change to DashboardContainerView.css

I believe this z-index property to be unnecessary.
Comment 3 Joseph Pecoraro 2014-04-25 14:47:46 PDT
Comment on attachment 230207 [details]
[PATCH] Proposed Fix: Change to DashboardContainerView.css

Do we know why this z-index was added originally? I think Brian Burg added it with:
<https://webkit.org/b/129898> Web Inspector: convert the dashboard toolbar item to support multiple dashboards
Comment 4 Jonathan Wells 2014-04-25 15:17:57 PDT
Created attachment 230212 [details]
[PATCH] Proposed Fix: Change to DashboardContainerView.css, Popover.css
Comment 5 WebKit Commit Bot 2014-04-25 16:43:47 PDT
Comment on attachment 230212 [details]
[PATCH] Proposed Fix: Change to DashboardContainerView.css, Popover.css

Clearing flags on attachment: 230212

Committed r167833: <http://trac.webkit.org/changeset/167833>
Comment 6 WebKit Commit Bot 2014-04-25 16:43:50 PDT
All reviewed patches have been landed.  Closing bug.
Comment 7 Antoine Quint 2014-04-26 01:54:23 PDT
Was there a screenshot of the original issue? Sounds to me like a popover should be laid out over the dashboard.