Bug 132195 – Allow a platform-specific size enumeration to be passed into popup-menu display

• Status: RESOLVED
• Resolution: FIXED
• Component: Forms

[Dean Jackson]

Allow a platform-specific size enumeration to be passed into popup-menu display

[Dean Jackson]

Created attachment 230181 [details]
Patch

[Dean Jackson]

This will fail to compile due to required changes in WebKitSystemInterface.

<rdar://problem/16175750>

[Brent Fulgham]

Comment on attachment 230181 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=230181&action=review

r=me. It looks like no similar changes are needed for iOS, right?

> Source/WebKit2/WebProcess/WebCoreSupport/mac/WebPopupMenuMac.mm:38
> +void WebPopupMenu::setUpPlatformData(const IntRect& pageRect, PlatformPopupMenuData& data)

It doesn't seem like you use pageRect anywhere.

[Dean Jackson]

(In reply to comment #3)
> (From update of attachment 230181 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=230181&action=review
> 
> r=me. It looks like no similar changes are needed for iOS, right?

No. iOS uses something completely different for popup menus.

[Dean Jackson]

Created attachment 230188 [details]
Updated patch for building

[Dean Jackson]

Committed r167825: <http://trac.webkit.org/changeset/167825>

[Brent Fulgham]

Comment on attachment 230188 [details]
Updated patch for building

Clearing review flag so it doesn't show up in the Request Queue.