Bug 132194 - REGRESSION(r167799): ASSERTION in parseGridTemplateShorthand in fast/css-grid-layout/grid-template-shorthand-get-set.html
Summary: REGRESSION(r167799): ASSERTION in parseGridTemplateShorthand in fast/css-grid...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 132197 (view as bug list)
Depends on:
Blocks:
 
Reported: 2014-04-25 07:04 PDT by Javier Fernandez
Modified: 2014-04-25 14:18 PDT (History)
12 users (show)

See Also:


Attachments
Patch (1.60 KB, patch)
2014-04-25 07:37 PDT, Javier Fernandez
no flags Details | Formatted Diff | Diff
Patch (5.02 KB, patch)
2014-04-25 13:29 PDT, Javier Fernandez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Javier Fernandez 2014-04-25 07:04:21 PDT
The change introduced in r167799 broke the Debug build because of an incorrect assertion. 

Im already working on a fix.
Comment 1 Javier Fernandez 2014-04-25 07:37:33 PDT
Created attachment 230179 [details]
Patch
Comment 2 Andrei Bucur 2014-04-25 07:39:05 PDT
Comment on attachment 230179 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2014-04-25 08:16:24 PDT
Comment on attachment 230179 [details]
Patch

Clearing flags on attachment: 230179

Committed r167806: <http://trac.webkit.org/changeset/167806>
Comment 4 WebKit Commit Bot 2014-04-25 08:16:27 PDT
All reviewed patches have been landed.  Closing bug.
Comment 6 Tim Horton 2014-04-25 10:04:18 PDT
Reopening.
Comment 7 Javier Fernandez 2014-04-25 10:09:25 PDT
(In reply to comment #6)
> Reopening.

I filed bug #132197 but I can provide the patch here, no problem. 
I'm already working on it
Comment 8 Tim Horton 2014-04-25 10:12:07 PDT
(In reply to comment #7)
> (In reply to comment #6)
> > Reopening.
> 
> I filed bug #132197 but I can provide the patch here, no problem. 
> I'm already working on it

Putting a little bit more information than "breaks debug tests" in the title might make them easier to find :D

Thanks for fixing!
Comment 9 Alexey Proskuryakov 2014-04-25 10:28:10 PDT
*** Bug 132197 has been marked as a duplicate of this bug. ***
Comment 10 Tim Horton 2014-04-25 11:23:35 PDT
Skipped on debug in http://trac.webkit.org/changeset/167812
Comment 11 Javier Fernandez 2014-04-25 13:29:27 PDT
Created attachment 230195 [details]
Patch

Fix for the Debug layout tests.
Comment 12 WebKit Commit Bot 2014-04-25 14:18:13 PDT
Comment on attachment 230195 [details]
Patch

Clearing flags on attachment: 230195

Committed r167821: <http://trac.webkit.org/changeset/167821>
Comment 13 WebKit Commit Bot 2014-04-25 14:18:19 PDT
All reviewed patches have been landed.  Closing bug.